nsqd: ability to configure auth endpoint path

[Misiu]

Hi there,
Currently when using -auth-http-address=host:port the endpoint is hardcoded to /auth

nsq/internal/auth/authorizations.go

Line 108 in c164c77

endpoint := fmt.Sprintf("http://%s/auth?%s", authd, v.Encode())

I have an identity server in my solution that is already using this endpoint. I'd like to be able to customize the URL, for example, I'd like to change it from /auth to /nsq/auth.

Also, I noticed that the docs don't describe the common_name parameter that can be used with auth.

[mreiferson]

seems reasonable to me, would you like to submit a PR?

[Misiu]

@mreiferson sadly I don't know GO at all, so it might be hard for me to set up the dev environment and do that small change in a correct way.
Maybe instead of adding another parameter, we could reuse auth-http-address, so if someone will enter a value containing / then we would do:
endpoint := fmt.Sprintf("http://%s?%s", authd, v.Encode())

So we should check if the value entered in that parameter contains / and then do a proper replacement.

The second option would be to add auth-http-endpoint, but as I wrote I have no GO experience, so I can't say what option would be better.

[tufanbarisyildirim]

Hi @Misiu setting the -auth-http-address option sth like -auth-http-address=auth.example.com/nsq worked for us, give it try maybe?. I also think, just checking the http prefix and not touching if it is already a url and just adding query params would be a good option. I would like to send a PR if that makes sense @mreiferson

so, this line

nsq/internal/auth/authorizations.go

Line 108 in c164c77

endpoint := fmt.Sprintf("http://%s/auth?%s", authd, v.Encode())

could be changed like, to keep it backward compatible.

	var endpoint string
	if strings.HasPrefix(authd, "http") {
		endpoint = fmt.Sprintf("%s?%s", authd, v.Encode())
	} else {
		endpoint = fmt.Sprintf("http://%s/auth?%s", authd, v.Encode())
	}

[mreiferson]

@tufanbarisyildirim sure, feel free to open a PR, thanks!