Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nsqlookupd: listen error lists incorrect address. #1270

Closed
TangDH03 opened this issue Jul 29, 2020 · 2 comments · Fixed by #1271
Closed

nsqlookupd: listen error lists incorrect address. #1270

TangDH03 opened this issue Jul 29, 2020 · 2 comments · Fixed by #1271
Labels

Comments

@TangDH03
Copy link
Contributor

File : nsq/nsqlookupd/nsqlookupd.go
Around line 43-46

l.httpListener, err = net.Listen("tcp", opts.HTTPAddress)
if err != nil {
	return nil, fmt.Errorf("listen (%s) failed - %s", opts.TCPAddress, err)
}

why it will print TCPAddress instead of HTTPAddress

@jehiah jehiah changed the title Why http connect error will print tcp address? nsqlookupd: listen error lists incorrect address. Jul 29, 2020
@jehiah jehiah added the bug label Jul 29, 2020
@jehiah
Copy link
Member

jehiah commented Jul 29, 2020

@TangDH03 good catch. Would you be interested in contributing a fix for this?

@TangDH03
Copy link
Contributor Author

Sure,I will raise a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants