Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WS Client support for CLI #3502

Open
AnnaShaleva opened this issue Jul 4, 2024 · 0 comments
Open

WS Client support for CLI #3502

AnnaShaleva opened this issue Jul 4, 2024 · 0 comments
Labels
cli Command line interface feature Completely new functionality I3 Minimal impact S4 Routine U4 Nothing urgent
Milestone

Comments

@AnnaShaleva
Copy link
Member

Is your feature request related to a problem? Please describe.

@532910 is always frustrated when he can't run neo-go query height with WS RPC server endpoint.

Suggestion is to add WS Client support to CLI.

Describe the solution you'd like

options.GetRPCClient may return interface instead of *rpcclient.Client and make an internal switch over http[s]:// and ws[s]:// to create either http or a web-socket client. The draft is in https://github.com/nspcc-dev/neo-go/tree/wss-height, the only thing we need is to move all methods required by CLI from RPC client to interface.

Describe alternatives you've considered

Leave everything as is.

@AnnaShaleva AnnaShaleva added feature Completely new functionality I3 Minimal impact U4 Nothing urgent cli Command line interface S4 Routine labels Jul 4, 2024
@AnnaShaleva AnnaShaleva added this to the v0.106.3 milestone Jul 4, 2024
@roman-khimov roman-khimov modified the milestones: v0.106.3, v0.106.4 Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Command line interface feature Completely new functionality I3 Minimal impact S4 Routine U4 Nothing urgent
Projects
None yet
Development

No branches or pull requests

2 participants