`nx migrate latest` fails on yarn 2 #5672

bryanforbes · 2021-05-14T20:37:37Z

Current Behavior

When running YARN_NODE_LINKER="node-modules" yarn nx migrate latest in a yarn 2 nx workspace, the process ends with Command failed: yarn add @nrwl/workspace@latest.

Expected Behavior

The workspace should be migrated to the latest version of nx

Steps to Reproduce

Run npm install -g yarn
Clone https://github.com/bryanforbes/nx-migrate-problem
Run yarn in the project
Run YARN_NODE_LINKER="node-modules" yarn nx migrate latest

Explanation for failure

After creating the temporary directory for tao, tao migrate latest is run from that environment. This command creates a new temporary directory and attempts to run yarn add @nrwl/workspace@latest which fails because no package.json exists. In the repo I linked above, I added a script called tao-yarn-add which emulates this failure by running yarn tao-yarn-add. This must be run via yarn in order to emulate calling yarn add and getting the yarn 2 engine. I've also added a script to package.json called tao-yarn-add-fixed that adds a package.json to the empty directory before calling yarn add and this fixes the issue. Again, this script must be run with yarn tao-yarn-add-fixed.

Failure Logs

❯ YARN_NODE_LINKER="node-modules" yarn nx migrate latest
Fetching meta data about packages.
It may take a few minutes.
Fetching @nrwl/workspace@latest

 ERROR  The migrate command failed.

Command failed: yarn add @nrwl/workspace@latest
/Users/bryan/Projects/ng12-test/node_modules/yargs/build/lib/yargs.js:1132
                throw err;
                ^

Error: Command failed: /var/folders/3k/v_hqdqq57l38tll9dwv0sgl80000gn/T/tmp-36776-kG6GoQPMMs7X/node_modules/.bin/tao migrate latest
    at checkExecSyncError (node:child_process:707:11)
    at Object.execSync (node:child_process:744:15)
    at Object.handler (/Users/bryan/Projects/ng12-test/node_modules/@nrwl/workspace/src/command-line/nx-commands.js:90:25)
    at Object.runCommand (/Users/bryan/Projects/ng12-test/node_modules/yargs/build/lib/command.js:196:48)
    at Object.parseArgs [as _parseArgs] (/Users/bryan/Projects/ng12-test/node_modules/yargs/build/lib/yargs.js:1043:55)
    at Object.get [as argv] (/Users/bryan/Projects/ng12-test/node_modules/yargs/build/lib/yargs.js:986:25)
    at Object.initLocal (/Users/bryan/Projects/ng12-test/node_modules/@nrwl/cli/lib/init-local.js:26:79)
    at Object.<anonymous> (/Users/bryan/Projects/ng12-test/node_modules/@nrwl/cli/bin/nx.js:43:18)
    at Module._compile (node:internal/modules/cjs/loader:1109:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1138:10) {
  status: 1,
  signal: null,
  output: [ null, null, null ],
  pid: 36778,
  stdout: null,
  stderr: null
}

Environment

Node : 16.1.0
OS : darwin x64
yarn : 2.4.1

nx : Not Found
@nrwl/angular : 12.2.0
@nrwl/cli : 12.2.0
@nrwl/cypress : 12.2.0
@nrwl/devkit : 12.2.0
@nrwl/eslint-plugin-nx : 12.2.0
@nrwl/express : Not Found
@nrwl/jest : 12.2.0
@nrwl/linter : 12.2.0
@nrwl/nest : Not Found
@nrwl/next : Not Found
@nrwl/node : Not Found
@nrwl/react : Not Found
@nrwl/schematics : Not Found
@nrwl/tao : 12.2.0
@nrwl/web : Not Found
@nrwl/workspace : 12.2.0
@nrwl/storybook : Not Found
@nrwl/gatsby : Not Found
typescript : 4.1.5

The text was updated successfully, but these errors were encountered:

fatihdogmus · 2021-05-21T08:24:56Z

Although my repo is not using yarn 2 workspaces, just regular yarn, I get the a similar error as above. It is just a toy project, but we will be using nx and angular in a project so encountering this problem could be a problem in the future.

Eror message:

> yarn nx migrate latest
yarn run v1.22.10
$ nx migrate latest
C:\Users\fatih.dogmus\IdeaProjects\angular-learning\node_modules\yargs\build\lib\yargs.js:1132
                throw err;
                ^

Error: Command failed: yarn
    at checkExecSyncError (node:child_process:682:11)
    at Object.execSync (node:child_process:719:15)
    at taoPath (C:\Users\fatih.dogmus\IdeaProjects\angular-learning\node_modules\@nrwl\workspace\src\command-line\nx-commands.js:312:21)
    at Object.handler (C:\Users\fatih.dogmus\IdeaProjects\angular-learning\node_modules\@nrwl\workspace\src\command-line\nx-commands.js:86:19)
    at Object.runCommand (C:\Users\fatih.dogmus\IdeaProjects\angular-learning\node_modules\yargs\build\lib\command.js:196:48)
    at Object.parseArgs [as _parseArgs] (C:\Users\fatih.dogmus\IdeaProjects\angular-learning\node_modules\yargs\build\lib\yargs.js:1043:55)
    at Object.get [as argv] (C:\Users\fatih.dogmus\IdeaProjects\angular-learning\node_modules\yargs\build\lib\yargs.js:986:25)
    at Object.initLocal (C:\Users\fatih.dogmus\IdeaProjects\angular-learning\node_modules\@nrwl\cli\lib\init-local.js:24:13)
    at Object.<anonymous> (C:\Users\fatih.dogmus\IdeaProjects\angular-learning\node_modules\@nrwl\cli\bin\nx.js:43:18)
    at Module._compile (node:internal/modules/cjs/loader:1108:14) {
  status: 1,
  signal: null,
  output: [ null, null, null ],
  pid: 26920,
  stdout: null,
  stderr: null
}
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Enviorenment:
OS: Windows 10 Enterprise Version 20H2
Yarn: V1.2210
Node.js: v15.6.0

Depndencies
nx : Not Found
@nrwl/angular : 12.0.6
@nrwl/cli : 12.0.6
@nrwl/cypress : 12.0.6
@nrwl/devkit : 12.0.6
@nrwl/eslint-plugin-nx : 12.0.6
@nrwl/express : Not Found
@nrwl/jest : 12.0.6
@nrwl/linter : 12.0.6
@nrwl/nest : Not Found
@nrwl/next : Not Found
@nrwl/node : Not Found
@nrwl/react : Not Found
@nrwl/schematics : Not Found
@nrwl/tao : 12.0.6
@nrwl/web : Not Found
@nrwl/workspace : 12.0.6
@nrwl/storybook : Not Found
@nrwl/gatsby : Not Found
typescript : 4.1.5

nemonemi · 2021-05-24T16:12:37Z

With Yarn 2 here, same problem different message:
yarn nx migrate latest

 yarn nx migrate latest
The system cannot find the path specified.
C:\www\path_to_project\node_modules\yargs\build\lib\yargs.js:1132
                throw err;
                ^

Error: Command failed: C:\Users\***\AppData\Local\Temp\tmp-29160-kCrQrVmtn2Bd\node_modules\.bin\tao migrate latest
    at checkExecSyncError (child_process.js:616:11)
    at Object.execSync (child_process.js:652:15)
    at Object.handler (C:\www\path_to_project\node_modules\@nrwl\workspace\src\command-line\nx-commands.js:90:25)
    at Object.runCommand (C:\www\path_to_project\node_modules\yargs\build\lib\command.js:196:48)
    at Object.parseArgs [as _parseArgs] (C:\www\path_to_project\node_modules\yargs\build\lib\yargs.js:1043:55)
    at Object.get [as argv] (C:\www\path_to_project\node_modules\yargs\build\lib\yargs.js:986:25)
    at Object.initLocal (C:\www\path_to_project\node_modules\@nrwl\cli\lib\init-local.js:26:79)
    at Object.<anonymous> (C:\www\path_to_project\node_modules\@nrwl\cli\bin\nx.js:43:18)
    at Module._compile (internal/modules/cjs/loader.js:1063:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1092:10) {
  status: 1,
  signal: null,
  output: [ null, null, null ],
  pid: 32980,
  stdout: null,
  stderr: null
}

nx report

 Node : 14.16.0
  OS   : win32 x64
  yarn : 2.4.1

  nx : Not Found
  @nrwl/angular : Not Found
  @nrwl/cli : 12.1.1
  @nrwl/cypress : 12.1.1
  @nrwl/devkit : 12.1.1
  @nrwl/eslint-plugin-nx : 12.1.1
  @nrwl/express : Not Found
  @nrwl/jest : 12.1.1
  @nrwl/linter : 12.1.1
  @nrwl/nest : Not Found
  @nrwl/next : Not Found
  @nrwl/node : Not Found
  @nrwl/react : 12.1.1
  @nrwl/schematics : 8.12.11
  @nrwl/tao : 12.1.1
  @nrwl/web : 12.1.1
  @nrwl/workspace : 12.1.1
  @nrwl/storybook : 12.1.1
  @nrwl/gatsby : Not Found
  typescript : 4.2.4

luejerry · 2021-05-27T13:27:16Z

@fatihdogmus I encountered the same error and it turned out to be the Angular CLI not supporting my installed version of Node (v16, see issue: angular/angular-cli#20796 ). Running nx migrate latest with Node v14 resolved it for me.

fatihdogmus · 2021-05-27T15:56:38Z

@luejerry yes! that was exactly the reason! I downgraded the version to 14.17.0 and it worked. Thx a lot

bryanforbes · 2021-05-27T16:04:34Z

Yarn 2 ignores the engine requirements, so Angular 12 should be fine on Yarn 2 + Node 16 and won't stop the install

akryvasheyeu · 2021-05-27T16:24:18Z

It works with node v14, with v16 not, same exception on migration from 12.2.0 to 12.3.5

bryanforbes · 2021-05-27T18:51:03Z

For the record, the reproduction repo still fails with node 14.17.0.

raphzandrade · 2021-08-24T18:55:05Z

Still having issues with this.

sushruth · 2021-09-07T01:52:49Z

For what its worth, using NX_MIGRATE_USE_LOCAL=true variable helped use the local version of nx for this. This may help you unblock until the next error.

EDIT: I also had to unplug @nrwl/tao and modify it to get it to work - modify migrate.js (from the error message) to create package.json (content: {name:"temp"}) in the temp directory and I was able to migrate to next.

I also removed unplug metadata from my main package.json and run yarn again and it all worked out.

insanicly · 2021-10-21T08:33:26Z

this is still an issue. I am getting the same error with the below configuration:
yarn nx --version 12.9.0

yarn --version 3.0.2

node --version v14.18.0

sledorze · 2021-11-09T21:12:28Z

Here's a recipe that worked for me:

First, MAKE SURE YOU DON'T HAVE a ".npmrc" file in your repo, otherwise, it won't work.

Applying this patch (which creates the temp file in the repo):

diff --git a/src/commands/migrate.js b/src/commands/migrate.js
index fe11e0558eeede06642d21f307ee18c2ca0d24d5..a1e4874846bc9e4a67fd18b9db5021de243bd751 100644
--- a/src/commands/migrate.js
+++ b/src/commands/migrate.js
@@ -317,7 +317,7 @@ function createFetcher() {
     return function f(packageName, packageVersion) {
         return tslib_1.__awaiter(this, void 0, void 0, function* () {
             if (!cache[`${packageName}-${packageVersion}`]) {
-                const dir = tmp_1.dirSync().name;
+                const dir = tmp_1.dirSync({ tmpdir:process.cwd() }).name;
                 const npmrc = checkForNPMRC();
                 if (npmrc) {
                     // Creating a package.json is needed for .npmrc to resolve

Like so:

"@nrwl/tao": "patch:@nrwl/tao@13.1.3#patches/nx-tao-patch.patch",

(provided the patch above is saved under "patches/nx-tao-patch.patch" in the repo)

AND

call the migration like this (thanks @sushruth ):

NX_MIGRATE_USE_LOCAL=true yarn nx migrate latest

Works for me!

benpsnyder · 2021-11-26T20:35:19Z

Here is how I am using Yarn v3 successfully.

Start with yarn install using Yarn v1

Then run yarn set version berry and follow that up with yarn set version 3.x (because berry has a bug)

Addd nodeLinker: node-modules to .yarnrc.yml

Run yarn install and update your .gitignore with

.pnp.*
.yarn/*
!.yarn/patches
!.yarn/plugins
!.yarn/releases
!.yarn/sdks
!.yarn/versions

Then commit.

I am having no issues with Yarn v3 and updating Nx 👯

Crack a beer.

benpsnyder · 2021-11-27T02:51:37Z

Y'all might be interested in feat(core): implement Yarn v3

devinshoemaker · 2022-01-04T18:25:01Z

Can confirm this issue using Yarn 1 with Node 16. Switching to Node 14 for the migration seems to work.

nemonemi · 2022-02-28T12:05:36Z

One use case to contribute is if you run it with yarn nx migrate... it fails, but with global nx migrate... it works.

AgentEnder · 2022-06-10T17:21:01Z

I think this particular issue has been fixed, since we now create package.json for any folder that receives packages temporarily as it is required to obey .npmrc.

There may still be things broken w/ yarn 2 and pnp, those are tracked via #2386.

I'm going to close this out in favor of that issue. I can't provide any updates as to yarn 2 / pnp support, but it is something that we are aware of.

github-actions · 2023-03-21T18:07:05Z

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

bryanforbes added the type: bug label May 14, 2021

FrozenPandaz added the scope: core core nx functionality label May 14, 2021

benpsnyder mentioned this issue Nov 27, 2021

feat(core): upgrade yarn v1 => v3 [berry] && replace npx with yarn dlx #7918

Closed

westmark mentioned this issue Dec 9, 2021

Cannot migrate to v13.2 #7866

Closed

AgentEnder closed this as completed Jun 10, 2022

github-actions bot added the outdated label Mar 21, 2023

github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`nx migrate latest` fails on yarn 2 #5672

`nx migrate latest` fails on yarn 2 #5672

bryanforbes commented May 14, 2021

fatihdogmus commented May 21, 2021 •

edited

Loading

nemonemi commented May 24, 2021 •

edited

Loading

luejerry commented May 27, 2021 •

edited

Loading

fatihdogmus commented May 27, 2021

bryanforbes commented May 27, 2021

akryvasheyeu commented May 27, 2021

bryanforbes commented May 27, 2021

raphzandrade commented Aug 24, 2021

sushruth commented Sep 7, 2021 •

edited

Loading

insanicly commented Oct 21, 2021

sledorze commented Nov 9, 2021

benpsnyder commented Nov 26, 2021

benpsnyder commented Nov 27, 2021

devinshoemaker commented Jan 4, 2022

nemonemi commented Feb 28, 2022

AgentEnder commented Jun 10, 2022

github-actions bot commented Mar 21, 2023

nx migrate latest fails on yarn 2 #5672

nx migrate latest fails on yarn 2 #5672

Comments

bryanforbes commented May 14, 2021

Current Behavior

Expected Behavior

Steps to Reproduce

Explanation for failure

Failure Logs

Environment

fatihdogmus commented May 21, 2021 • edited Loading

nemonemi commented May 24, 2021 • edited Loading

luejerry commented May 27, 2021 • edited Loading

fatihdogmus commented May 27, 2021

bryanforbes commented May 27, 2021

akryvasheyeu commented May 27, 2021

bryanforbes commented May 27, 2021

raphzandrade commented Aug 24, 2021

sushruth commented Sep 7, 2021 • edited Loading

insanicly commented Oct 21, 2021

sledorze commented Nov 9, 2021

benpsnyder commented Nov 26, 2021

benpsnyder commented Nov 27, 2021

devinshoemaker commented Jan 4, 2022

nemonemi commented Feb 28, 2022

AgentEnder commented Jun 10, 2022

github-actions bot commented Mar 21, 2023

`nx migrate latest` fails on yarn 2 #5672

`nx migrate latest` fails on yarn 2 #5672

fatihdogmus commented May 21, 2021 •

edited

Loading

nemonemi commented May 24, 2021 •

edited

Loading

luejerry commented May 27, 2021 •

edited

Loading

sushruth commented Sep 7, 2021 •

edited

Loading