generatePackageJson adds @angular/{common/core} to Node project #4939
Comments
juristr
added
the
scope: node
|
@the-ult it would be really helpful if you can share a repro repo. Can you also check if your issue is solved using |
|
Hi, sharing the repo would be difficult. But I wil try the |
|
The beta still seems to include the
However.
import { GraphQLEnvironment } from '@ddb/shared/environment';
export const environment: GraphQLEnvironment = {
..
}The /// This module is NOT imported in the ddb-graphql-server
import { ModuleWithProviders, NgModule } from '@angular/core';
import { CommonModule } from '@angular/common';
import { ClientEnvironment } from './environment.model';
import { ENV } from './environment.token';
@NgModule({
imports: [CommonModule],
})
export class EnvironmentModule {
static forRoot(environment: Partial<ClientEnvironment>): ModuleWithProviders<EnvironmentModule> {
return {
ngModule: EnvironmentModule,
providers: [{ provide: ENV, useValue: environment }],
};
}
}--
export const environment = {
...
}
I figured, since we are only importing the |
|
@the-ult Thanks for trying it out and debugging this 👍 This sounds like an issue with our project graph calculation 🤔 tbh, I am not super familiar with that part of the code but if you can create a a minimal repro I can investigate it. |
|
Thanks. |
|
Hi @bekos
the shared-environment is an angular-lib. the |
|
@bekos have you had any chance to try the sample repo? |
|
@the-ult I took a look, and based on the current implementation, I'm afraid there is no workaround, as Nx calculates dependencies based on the relation of the files and not on the actual imports. An alternative suggestion is to use something like |
|
Thanks for looking into it |
|
Closing as it is not actionable atm, imo the best approach in these cases is to generate (even manually) the appropriate |
|
Ok.. found out what caused the problem. We were using/importing an import { GraphQLEnvironment } from '@ddb/shared/environment';
export const environment: GraphQLEnvironment = {
...
}However.. The // shared/environment/src/index.ts
export * from './lib/shared-environment.module';
export * from './lib/environment-versions';
export * from './lib/environment.model';
export { DdbEnvironmentService } from './lib/environment.service';I was in the (wrong) assumption that only actually used/imported files would be used. But it seems when you import 1 item from the package.. Alle files/dependencies of the Will this not be the case if we use (better) secondary-entrypoints / barrel files? related to: #6574 |
|
This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context. |
Current Behavior
We've got an Apollo/Express graphql-server and are using
"generatePackageJson": true,to generate thepackage.jsonfor the production build of the graphql-server.The generated
package.jsonadds@angular/commonand@angular/coreas dependencies, while it isn't an Angular project. And@angular/...is not used in the project.Expected Behavior
The generated
package.jsonshould not include the@angular/..dependenciesSteps to Reproduce
The generated package.json
{ "name": "my-graphql-server", "version": "0.0.1", "main": "main.js", "dependencies": { "@angular/common": "11.2.3", // would not expect the package.json to have these "@angular/core": "11.2.3", // would not expect the package.json to have these "apollo-datasource-rest": "0.10.0", "apollo-server-express": "2.21.0", "compression": "1.7.4", "express": "4.17.1", "graphql-import-node": "0.0.4", "graphql-modules": "1.4.1", "graphql-scalars": "~1.8.0", "graphql-subscriptions": "1.2.0", "graphql": "15.5.0", "js-yaml": "4.0.0", "log4js": "6.3.0", "reflect-metadata": "0.1.13", "rxjs": "6.6.6" } }angular.jsonEnvironment
The text was updated successfully, but these errors were encountered: