-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generating a new library automatically edits nx.json by adding the nx-eslint plugin causing random performance issues #26953
Comments
Adding the |
In VS code, we are getting this error, when this plugin is added:
Which results into Nx Console Extension not working. |
@CaiZhe @FrancescoBorzi same issue over here |
Hey! {
"plugin": "@nx/eslint/plugin",
"include": ["path/to/lib/**/*"],
"options": {
"targetName": "lint"
}
}, After the first time this plugin is added, it's entirely feasible that project graph calculation will take a bit longer. If you're still seeing performance issues on the latest For Nx Console, that error looks like you pressed the reload button while the project graph was still being computed. We will add better handling there so that no error pops up. If you still see the error above after a restart of the editor, please create a new issue in nrwl/nx-console and I will have a look! Thank you. |
This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context. |
Current Behavior
I'm using NX version
18.3.5
at work.19.4.3
and the problem is still the same. However, with NX17.2.4
there is no such issue.Whenever I add a new library using the command:
The following code gets automatically added to the
nx.json
file of the project:For some reasons, this causes big performance issues to some colleagues (not to myself) whenever they open the same project with their editors.
This happened already twice and it took us quite some time to debug and figure out what was causing the issue. It is still not clear why NX changes the global
nx.json
configuration when performing the task of creating a new library.Note: this does not happen if using NX 17, but only when using NX 18 or NX 19
Expected Behavior
Generating a new library should not create any unexpected side-effect.
GitHub Repo
https://github.com/FrancescoBorzi/nx-test-project
Steps to Reproduce
npm i
npx nx g @nx/js:lib
"plugins"
section is added tonx.json
Nx Report
Failure Logs
No response
Package Manager Version
npm --version: 10.8.2
Operating System
Additional Information
No response
The text was updated successfully, but these errors were encountered: