Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nx Google Pay: Missing annotations With stripe #14414

Closed
affansk opened this issue Jan 17, 2023 · 5 comments
Closed

Nx Google Pay: Missing annotations With stripe #14414

affansk opened this issue Jan 17, 2023 · 5 comments
Labels

Comments

@affansk
Copy link

affansk commented Jan 17, 2023

Current Behavior

while trying to build with nx getting this googlepay_button_dark.xml: Error: is not annotated
react native version 0.71.0

Expected Behavior

the app should built without any issue

Github Repo

No response

Steps to Reproduce

upgrade to react native 0.71.0 with stripe available in package
2) run nx command
3) user will see similar error googlepay_button_dark.xml is not annotated as @input

Nx Report

upgrade to react native 0.71.0 with stripe available in package
2) run nx command
3) user will see similar error **googlepay_button_dark.xml is not annotated as @Input**

Failure Logs

No response

Additional Information

No response

@affansk affansk changed the title Nx Google Pay: Missing annotations Nx Google Pay: Missing annotations With stripe Jan 17, 2023
@affansk
Copy link
Author

affansk commented Jan 17, 2023

@FrozenPandaz FrozenPandaz added the scope: react-native Issues relating to React Native label Jan 18, 2023
@affansk
Copy link
Author

affansk commented Jan 19, 2023

@FrozenPandaz Any Solution you can suggest for this issue ?

@Peeeep
Copy link

Peeeep commented Jan 24, 2023

Posting here for visibility, in case someone stumbles over the same problem:

I've fixed this issue by using patch-package to patch the @react-native-community/cli-platform-android package so it loads the dependencies from the root node_modules folder. The issue definitely seems to be related to symlinks, which gradle doesn't know how to handle (at least it seems that way from my research). Here's the patch:

diff --git a/node_modules/@react-native-community/cli-platform-android/native_modules.gradle b/node_modules/@react-native-community/cli-platform-android/native_modules.gradle
index 4a63eaf..05b4511 100644
--- a/node_modules/@react-native-community/cli-platform-android/native_modules.gradle
+++ b/node_modules/@react-native-community/cli-platform-android/native_modules.gradle
@@ -469,7 +469,7 @@ class ReactNativeModules {
         def nameCleansed = name.replaceAll('[~*!\'()]+', '_').replaceAll('^@([\\w-.]+)/', '$1_')
         reactNativeModuleConfig.put("name", name)
         reactNativeModuleConfig.put("nameCleansed", nameCleansed)
-        reactNativeModuleConfig.put("androidSourceDir", androidConfig["sourceDir"])
+        reactNativeModuleConfig.put("androidSourceDir", androidConfig["sourceDir"].replace('apps/your-app-name/', ""))
         reactNativeModuleConfig.put("packageInstance", androidConfig["packageInstance"])
         reactNativeModuleConfig.put("packageImportPath", androidConfig["packageImportPath"])
         reactNativeModuleConfig.put("libraryName", androidConfig["libraryName"])

Originally posted by @retro in stripe/stripe-react-native#1078 (comment)

@github-actions
Copy link

This issue has been automatically marked as stale because it hasn't had any recent activity. It will be closed in 14 days if no further activity occurs.
If we missed this issue please reply to keep it active.
Thanks for being a part of the Nx community! 🙏

@github-actions
Copy link

github-actions bot commented Sep 8, 2023

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants