Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nx version 15.4 not forwarding arguments to run-many? #14050

Closed
jgarciaokode opened this issue Dec 29, 2022 · 6 comments
Closed

Nx version 15.4 not forwarding arguments to run-many? #14050

jgarciaokode opened this issue Dec 29, 2022 · 6 comments
Labels
blocked: retry with latest Retry with latest release or head. outdated scope: core core nx functionality type: bug

Comments

@jgarciaokode
Copy link

jgarciaokode commented Dec 29, 2022

Current Behavior

In Nx v14.8.3 when you run nx run-many --target deploy --options="--all" then the options arg is being passed to all executors, therefore as we have a cdk with multiple stacks, the pipeline does not exit with error asking to supply which cdk stack should be deployed

Screenshot 2022-12-29 at 12 38 40

However, in Nx v15.4.1, when you run exactly the same command, the arg is not being passed (it seems) and therefore, the pipeline exists with error

image

I tried with nx:run-commands executors and the same applies, the thing is that if you run nx run :deploy --all it is working since the arguments are being forwarded

Expected Behavior

As described, same behaviour than Nx 14.8.3, arguments being forwarded in run-many command

Github Repo

No response

Steps to Reproduce

d

Nx Report

 >  NX   Report complete - copy this into the issue template

   Node : 16.18.1
   OS   : darwin arm64
   npm  : 8.19.2

   nx : 15.4.1
   @nrwl/angular : 15.4.1
   @nrwl/cypress : 15.4.1
   @nrwl/detox : Not Found
   @nrwl/devkit : 15.4.1
   @nrwl/esbuild : Not Found
   @nrwl/eslint-plugin-nx : 15.4.1
   @nrwl/expo : Not Found
   @nrwl/express : Not Found
   @nrwl/jest : 15.4.1
   @nrwl/js : 15.4.1
   @nrwl/linter : 15.4.1
   @nrwl/nest : Not Found
   @nrwl/next : Not Found
   @nrwl/node : Not Found
   @nrwl/nx-cloud : Not Found
   @nrwl/nx-plugin : Not Found
   @nrwl/react : Not Found
   @nrwl/react-native : Not Found
   @nrwl/rollup : 15.4.1
   @nrwl/schematics : Not Found
   @nrwl/storybook : 15.4.1
   @nrwl/web : 15.4.1
   @nrwl/webpack : 15.4.1
   @nrwl/workspace : 15.4.1
   typescript : 4.8.4
   ---------------------------------------
   Local workspace plugins:
   ---------------------------------------
   Community plugins:
         @otterdev/nx-cdk: 0.0.14
         @storybook/angular: 6.5.15

Failure Logs

No response

Additional Information

No response

@jgarciaokode
Copy link
Author

In nx version 15.3.3 it is working correctly, it seems like the change in run-many command in 15.4 broke this behaviour

image

@ysdidenko
Copy link
Contributor

Same here. In 15.4.2 just ignores params we pass to nx:affected

@AgentEnder
Copy link
Member

@jgarciaokode I believe this should have been fixed by #14031. Can you try 15.4.2 and see if it is working for you?

@AgentEnder AgentEnder added blocked: retry with latest Retry with latest release or head. scope: core core nx functionality labels Dec 29, 2022
@jgarciaokode
Copy link
Author

jgarciaokode commented Dec 30, 2022

@AgentEnder yes, it is working in 15.4.2 Thanks for the quick answer ^^

@ysdidenko
Copy link
Contributor

Hi @AgentEnder, it works locally, but still swallowing the arguments on Azure with nx-cloud, could you advise, please?

@github-actions
Copy link

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
blocked: retry with latest Retry with latest release or head. outdated scope: core core nx functionality type: bug
Projects
None yet
Development

No branches or pull requests

3 participants