Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add POIs in the exported route #222

Closed
bagage opened this issue Jul 28, 2019 · 4 comments · Fixed by #226
Closed

Add POIs in the exported route #222

bagage opened this issue Jul 28, 2019 · 4 comments · Fixed by #226
Assignees
Milestone

Comments

@bagage
Copy link
Collaborator

bagage commented Jul 28, 2019

I thought that there was already an issue about that, but I'd like to:

  • draw points on BRouter website, and enter a name for each
  • then, when exporting the route (at least as GPX), export these points as waypoints.

GPX syntax is:

<gpx>
  <wpt lon="3.866962" lat="43.674468">
    <name>My POI to visit</name>
  </wpt>
 <trk>...</trk>
</gpx>
@bagage
Copy link
Collaborator Author

bagage commented Jul 28, 2019

NVM, it was on brouter engine side: abrensch/brouter#91

I can see that you @Phyks already started working on it. Have you a plan for brouter-web side?

@Phyks
Copy link
Contributor

Phyks commented Jul 28, 2019

I started to work on the BRouter side, adding an exportWaypoints parameter to export them in the traces (any file format). This is currently a boolean exporting all (from, to, via) or nothing.

This is replicated in brouter-web in #221, but still very basic.

@bagage
Copy link
Collaborator Author

bagage commented Jul 28, 2019

Indeed we talked about it and indeed currently we can export brouter
image markers as waypoints (from, to and via).

I'll add a button in brouter-web to add another type of waypoints, which are "not on the route" markers (nearby restaurants, campings, etc.), where one can add some custom text. Is that ok for you @nrenner @Phyks?

@nrenner
Copy link
Owner

nrenner commented Aug 1, 2019

Ok for me (although encoding user input is not properly solved yet, will create an issue with a suggestion). Would be useful for all formats.

@bagage bagage changed the title Add POIs in the exported route (gpx only?) Add POIs in the exported route Aug 19, 2019
@bagage bagage self-assigned this Oct 2, 2019
@nrenner nrenner added this to the 0.11.0 milestone Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants