Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(workspaces): let execWorkspaces get workspaces config #312

Closed
wraithgar opened this issue Mar 25, 2021 · 0 comments
Closed

refactor(workspaces): let execWorkspaces get workspaces config #312

wraithgar opened this issue Mar 25, 2021 · 0 comments

Comments

@wraithgar
Copy link
Member

wraithgar commented Mar 25, 2021

If we move the npm.config.get('workspace') out of lib/npm.js and let the execWorkspaces functions do that themselves it will be more clear inside the exec functions what's going on, and likely lead to more optimizations down the road inside each command (i.e. set a "use workspaces" flag and reuse all the rest of the code or something).

This should wait till the velocity on adding workspace-aware commands has slowed down. This is cleanup for afterwards.

Alternatively we could move the getWorkspaces util function up into lib/npm.js itself, so that what execWorkspaces gets passed is already standardized off of what's in there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants