Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(workspaces): throw warning /w messaging for unsupported commands #269

Closed
29 tasks done
darcyclarke opened this issue Mar 2, 2021 · 0 comments · Fixed by npm/cli#2864
Closed
29 tasks done

feat(workspaces): throw warning /w messaging for unsupported commands #269

darcyclarke opened this issue Mar 2, 2021 · 0 comments · Fixed by npm/cli#2864
Assignees
@ruyadorno
Milestone
OSS - Sprint 26

Comments

@darcyclarke
Copy link
Contributor

darcyclarke commented Mar 2, 2021 •
edited
Loading

Problem statement

Not all of npm's commands make sense to be workspace-aware.

Exit criteria

  • All of the following commands should warn & display an unsupported message when workspace options are passed
  • Tests are written validating this behavior
  • Documentation is updated to identify these commands as not supporting -w / workspaces

Unsupported commands:

  • adduser|login
  • bin
  • birthday
  • cache
  • completion
  • config|get|set
  • deprecate
  • doctor
  • edit
  • explore
  • help
  • help-search
  • hook
  • logout
  • org
  • owner
  • ping
  • prefix
  • profile
  • search
  • shrinkwrap
  • star
  • team
  • token
  • unstar
  • whoami
@darcyclarke darcyclarke changed the title feat: throw error & messaging for unsupported commands feat(workspace): throw error & messaging for unsupported commands Mar 2, 2021
@darcyclarke darcyclarke changed the title feat(workspace): throw error & messaging for unsupported commands feat(workspaces): throw error & messaging for unsupported commands Mar 2, 2021
@darcyclarke darcyclarke changed the title feat(workspaces): throw error & messaging for unsupported commands feat(workspaces): throw error /w messaging for unsupported commands Mar 2, 2021
@darcyclarke darcyclarke added this to the OSS - Sprint 25 milestone Mar 2, 2021
@darcyclarke darcyclarke changed the title feat(workspaces): throw error /w messaging for unsupported commands feat(workspaces): throw error /w messaging for unsupported commands Mar 2, 2021
@darcyclarke darcyclarke added Epic and removed Backlog labels Mar 2, 2021
@darcyclarke darcyclarke changed the title feat(workspaces): throw error /w messaging for unsupported commands feat(workspaces): throw warning /w messaging for unsupported commands Mar 9, 2021
@ruyadorno ruyadorno mentioned this issue Mar 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ruyadorno ruyadorno

Labels
None yet
Projects
None yet
Milestone
OSS - Sprint 26
Development

Successfully merging a pull request may close this issue.

feat: add run-script workspaces ruyadorno/cli
2 participants
@ruyadorno @darcyclarke