fix: respect given algorithms instead of always using sha512 #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlf
force-pushed
the
nlf/fix-non-sha512-algorithms
branch
from
d058b0a to
7280ee5
Compare
nlf
force-pushed
the
nlf/fix-non-sha512-algorithms
branch
from
c4faac2 to
a0b473c
Compare
ruyadorno
approved these changes
May 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this corrects the issue where we write content with an expected sha1 integrity as sha512 causing us to effectively not cache it at all, now content is correctly written as sha1 and can be read from the cache appropriately