Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support non-public hosts such as GitHub Enterprise #39

Closed
rarkins opened this issue Aug 17, 2018 · 8 comments
Closed

Support non-public hosts such as GitHub Enterprise #39

rarkins opened this issue Aug 17, 2018 · 8 comments

Comments

@rarkins
Copy link

rarkins commented Aug 17, 2018

I thought it would be best to break this out into its own issue.

Is it the intention to support non-public hosts like this?

e.g. its use might look like:

var info = hostedGitInfo.fromUrl("git@github.mycompany.com:abc/def.git")

but could also look like:

var info = hostedGitInfo.fromUrl("git@code.mycompany.com:abc/def.git")

There's nothing about the above that says "this is of type github" and it could just as easily be gitlab instead. But perhaps it's possible to at least return as much info as possible, e.g.

/* info looks like:
{
type: "unknown",
domain: "code.mycompany.com",
user: "abc",
project: "def"
}
*/

@hutson
Copy link

hutson commented Oct 16, 2018

You may be interested in #11 and this comment - #11 (comment)

@dcyriller
Copy link

@hutson the solution above wouldn't solve the issue you're pointing to. But it would provide with a nice fallback. Would you accept a PR implementing the fallback?

@hutson
Copy link

hutson commented Mar 18, 2019

Would you accept a PR implementing the fallback?

I'm not with npm. You would need to ask them 😅

@dcyriller
Copy link

@iarna would it make sense?

(thank you @hutson)

@privatenumber
Copy link

Having this issue here sindresorhus/np#357 and would love to see it implemented!

@spurreiter
Copy link

Hi I have solved this issue for me using an option flag {allowOtherHosts: true}. On interest pls check this fork https://github.com/spurreiter/hosted-git-info/tree/feature-allow-other-hosts. As of #11 comment I am not sure if it's worth the PR. Any advise?

@AnoLu
Copy link

AnoLu commented Oct 14, 2021

the Gitlab Enterprise hosts is not supported too, like: 'git+https://oauth2:TOKEN@gitlab.MYCOMPANY.com/PATH/TO/PROJECT.git#v1.0.5'

@dbrakman
Copy link

dbrakman commented Jan 4, 2023

I think this issue can be closed. In addition to #11, the maintainer @iarna commented more explicitly on #23 here that enterprise, self-hosted git hosts are out of scope for the tool named hosted-git-info.

@rarkins rarkins closed this as not planned Won't fix, can't repro, duplicate, stale Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants
@privatenumber @rarkins @dcyriller @hutson @dbrakman @spurreiter @AnoLu and others