Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] update node-gyp to 5.1 at the very least #927

Closed
Pomax opened this issue Feb 21, 2020 · 3 comments
Closed

[FEATURE] update node-gyp to 5.1 at the very least #927

Pomax opened this issue Feb 21, 2020 · 3 comments

Comments

@Pomax
Copy link

Pomax commented Feb 21, 2020

As Python 2.7 was finally abandoned on January 1st of this year and should no longer be a prerequisite for anything in the computing world (except maybe folks on macos, all of whom should have python3 installed anyway now that 2.7 is dead) it would be a good idea to bump the version of node-gyp to 5.1.0 or higher (see nodejs/node-gyp#2052)

@Pomax
Copy link
Author

Pomax commented Feb 21, 2020

Correction: a decisions was made late December of last year to push the date back to April first, 2020, so there's a few weeks left before Python 2.7 EOL yet. Of course, it would still be wise to uplift node-gyp before then.

@ljharb
Copy link
Contributor

ljharb commented Feb 21, 2020

See #771, #287.

@Pomax
Copy link
Author

Pomax commented Feb 21, 2020

perfect, closing as duplicate.

(hopefully the PRs won't go stale over travis not passing...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants