Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: discrete npm doctor commands #5888

Merged
merged 4 commits into from
Dec 7, 2022
Merged

feat: discrete npm doctor commands #5888

merged 4 commits into from
Dec 7, 2022

Conversation

wraithgar
Copy link
Member

@wraithgar wraithgar commented Nov 22, 2022

Changed output to display as each check finishes instead of all at once at the end.

Check added: checkBinPath. Checks that the global bin is in your path.

Added grouping to commands.

@wraithgar wraithgar requested a review from a team as a code owner November 22, 2022 20:58
@npm-cli-bot
Copy link
Collaborator

npm-cli-bot commented Nov 22, 2022

no statistically significant performance changes detected

timing results
app-large clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 35.125 ±1.69 17.855 ±0.05 16.415 ±0.04 19.241 ±1.13 3.034 ±0.08 2.985 ±0.04 2.440 ±0.13 11.423 ±0.04 2.441 ±0.05 4.010 ±0.55
#5888 32.664 ±1.77 17.561 ±0.17 16.226 ±0.25 19.302 ±1.36 3.112 ±0.13 2.986 ±0.01 2.367 ±0.06 11.360 ±0.01 2.334 ±0.01 3.883 ±0.71
app-medium clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 24.932 ±0.14 13.922 ±0.02 12.715 ±0.20 14.044 ±0.23 2.734 ±0.01 2.706 ±0.04 2.443 ±0.03 8.707 ±0.02 2.344 ±0.01 3.812 ±1.02
#5888 24.532 ±1.32 13.722 ±0.09 12.709 ±0.06 13.609 ±0.12 2.805 ±0.03 2.804 ±0.05 2.354 ±0.03 8.878 ±0.01 2.204 ±0.00 4.346 ±1.86

@wraithgar
Copy link
Member Author

I can edit this to include docs once we've bikeshed the subcommand names.

Copy link
Contributor

@fritzy fritzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far. We can bikeshed the subcommand name next standup.

@wraithgar wraithgar changed the title Discrete npm doctor commands / add environment check feat: discrete npm doctor commands Dec 6, 2022
Usage is driven by actual code, commands are tagged for grouping
Copy link
Contributor

@nlf nlf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unless there are objections, i think this makes sense to me. the groupings are named well enough to be intuitive.

@wraithgar wraithgar requested a review from fritzy December 6, 2022 20:57
@wraithgar
Copy link
Member Author

Please squash this one when merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants