Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] npm ls does not include root #3945

Closed
1 task done
Eomm opened this issue Oct 27, 2021 · 2 comments · Fixed by #4481
Closed
1 task done

[BUG] npm ls does not include root #3945

Eomm opened this issue Oct 27, 2021 · 2 comments · Fixed by #4481
Assignees
Labels
Bug thing that needs fixing Priority 1 high priority issue Release 8.x work is associated with a specific npm 8 release

Comments

@Eomm
Copy link
Contributor

Eomm commented Oct 27, 2021

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

Running the npm ls command within the --include-workspace-root does not change the output.

The outputs:

Correct

npm ls

npm-ls@1.0.0 /Users/mspigolon/workspace/_experiments/npm-workspaces/npm-ls
├── avvio@8.0.0
└─┬ pkg-a@1.0.0 -> ./pkg-a
  └── fastify@3.22.1

Correct

npm ls -w pkg-a

npm-ls@1.0.0 /Users/mspigolon/workspace/_experiments/npm-workspaces/npm-ls
└─┬ pkg-a@1.0.0 -> ./pkg-a
  └── fastify@3.22.1

Incorrect

npm ls -w pkg-a --include-workspace-root

npm-ls@1.0.0 /Users/mspigolon/workspace/_experiments/npm-workspaces/npm-ls
└─┬ pkg-a@1.0.0 -> ./pkg-a
  └── fastify@3.22.1

Expected Behavior

npm ls -w pkg-a --include-workspace-root should list the root package.json dependancies

Steps To Reproduce

mkdir npm-ls
cd npm-ls
npm init --yes
npm init -w pkg-a --yes
npm install avvio
npm install fastify -w pkg-a

Environment

  • OS: mac 11.6
  • Node: node 16.11.1
  • npm: 8.1.1
@Eomm Eomm added Bug thing that needs fixing Needs Triage needs review for next steps Release 8.x work is associated with a specific npm 8 release labels Oct 27, 2021
@darcyclarke darcyclarke removed the Needs Triage needs review for next steps label Jan 7, 2022
@darcyclarke
Copy link
Contributor

Can reproduce this on latest, npm@8.3.0

@darcyclarke darcyclarke added Priority 1 high priority issue and removed Priority 1 high priority issue labels Feb 22, 2022
@fritzy
Copy link
Contributor

fritzy commented Mar 2, 2022

This just got merged for this week's release.

@fritzy fritzy closed this as completed Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug thing that needs fixing Priority 1 high priority issue Release 8.x work is associated with a specific npm 8 release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants