Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Potential error in messaging for npm org #2432

Closed
snuggs opened this issue Jan 1, 2021 · 3 comments
Closed

[BUG] Potential error in messaging for npm org #2432

snuggs opened this issue Jan 1, 2021 · 3 comments
Labels
Bug thing that needs fixing Needs Triage needs review for next steps Release 6.x work is associated with a specific npm 6 release

Comments

@snuggs
Copy link
Contributor

snuggs commented Jan 1, 2021

Current Behavior:

@ruyadorno @darcyclarke @nlf pardon the nit. Was doing some package housekeeping and noticed something that just looks a little off with the messaging. "You now 3 members"? 🤔

Also wondering how the tests from #2353 are passing.

Thanks in advance! And let me know where I can help. ❤️ tests🙏🏽

See below:

Expected Behavior:

"Added bar to foo. You now have 1 member in this org."

Steps To Reproduce:

npm org set foo @bar admin

Environment:

  • OSX
  • Node: 14.15.3
  • npm: 6.14.10

Capture d’écran 2021-01-01 à 01 06 43
@snuggs snuggs added Bug thing that needs fixing Needs Triage needs review for next steps Release 6.x work is associated with a specific npm 6 release labels Jan 1, 2021
@alexa2140
Copy link

alexa2140 commented Jan 1, 2021 •
edited
Loading

Are these issues about websites?

@YC
Copy link

YC commented Jan 5, 2021 •
edited
Loading

I think https://github.com/npm/cli/pull/2353/files#diff-6853bcc6c7c067c12466503a6b1610bed8dddd128537a07fc6c90e2bda154c78R78 (996a2f6) fixed this problem.

@snuggs
Copy link
Contributor Author

snuggs commented Jan 5, 2021

@YC thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug thing that needs fixing Needs Triage needs review for next steps Release 6.x work is associated with a specific npm 6 release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@snuggs @darcyclarke @YC @alexa2140