-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support multiple set/get/deletes in npm config #2362
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaacs
force-pushed
the
isaacs/config-set-multi
branch
from
December 16, 2020 00:51
4faf5f3
to
8ccbdf2
Compare
|
isaacs
force-pushed
the
isaacs/config-set-multi
branch
from
December 16, 2020 01:06
8ccbdf2
to
8fd006a
Compare
darcyclarke
added
Release 7.x
work is associated with a specific npm 7 release
release: next
These items should be addressed in the next release
labels
Dec 16, 2020
nlf
approved these changes
Dec 18, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, nice little usability win here 🎉
isaacs
added a commit
that referenced
this pull request
Dec 18, 2020
While digging into #2300, I realized it would be a lot easier if we could do this: npm config set email=me@example.com _auth=xxxx and avoid the whole issue of what gets set first. Also, why not let `npm config get foo bar baz` return just the keys specified? Also updates the docs, including the statement that `npm config set foo` with no value sets it to `true`, when as far as I can tell, that has never been the case. PR-URL: #2362 Credit: @isaacs Close: #2362 Reviewed-by: @nlf
isaacs
force-pushed
the
isaacs/config-set-multi
branch
from
December 18, 2020 20:26
8fd006a
to
a9b8bf2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
release: next
These items should be addressed in the next release
Release 7.x
work is associated with a specific npm 7 release
semver:minor
new backwards-compatible feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While digging into #2300, I realized it would be a lot easier if we
could do this:
and avoid the whole issue of what gets set first.
Also, why not let
npm config get foo bar baz
return just the keysspecified?
Also updates the docs, including the statement that
npm config set foo
with no value sets it to
true
, when as far as I can tell, that hasnever been the case.
References