Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raise an error early if publishing without login, registry #2360

Closed

Conversation

isaacs
Copy link
Contributor

@isaacs isaacs commented Dec 15, 2020

Ran into this fixing #2300 in @npmcli/config, getting weird registry errors when trying to publish while my userconfig was still set to a test file.

References

@isaacs isaacs requested a review from a team as a code owner December 15, 2020 23:46
@npm-deploy-user
Copy link

npm-deploy-user commented Dec 15, 2020

angular-quickstart app-large app-medium ember-quickstart react-app
prev current status prev current status prev current status prev current status prev current status
initial install 41s 44.4s✅🐌 39.5s 53.1s🛑 34.5s 37.9s✅🐌 28.1s 29.9s✅🐌 33.5s 41.2s🛑
repeat install 9.6s 3.5s 8.6s 3.5s 8.3s 2.8s 7.7s 1.7s 9.1s 3.1s
with warm cache 32.3s 24.6s 33.8s 31.2s 31.3s 21s 23.4s 18.1s 29.1s 20.7s
with node_modules 9.2s 6.3s 8.6s 5.5s 9s 3.9s 7.8s 2.3s 9.4s 6.4s
with lockfile 32.6s 32.8s✅🐌 31s 34.6s🛑 29s 24.1s 21.7s 19.9s 27.4s 28.3s✅🐌
with warm cache and node_modules 9.3s 3.7s 7.9s 4.1s 8.4s 3.2s 7.6s 2.2s 9.2s 3.6s
with warm cache and lockfile 24.7s 11.2s 26.3s 15.1s 24.3s 9.1s 17.8s 7.1s 21.3s 8s
with node_modules and lockfile 10.1s 5.5s 9.8s 4.5s 8.6s 3.4s 7.8s 2.3s 9.7s 5.8s

@darcyclarke darcyclarke added Release 7.x work is associated with a specific npm 7 release release: next These items should be addressed in the next release labels Dec 16, 2020
@isaacs isaacs force-pushed the isaacs/publish-fail-when-no-registry-no-login branch from fa55ea3 to 15e3053 Compare December 18, 2020 00:48
Copy link
Contributor

@nlf nlf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fast failing is definitely the way to go here, this is great

@thw0rted
Copy link

Is it possible that this is why #1937 seems to have reverted for me? I don't think your registry option lookup is respecting publishConfig.registry.

@nlf nlf deleted the isaacs/publish-fail-when-no-registry-no-login branch March 28, 2022 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: next These items should be addressed in the next release Release 7.x work is associated with a specific npm 7 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants