Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix doctor test to work correctly for node pre-release versions #2358

Closed
wants to merge 0 commits into from

Conversation

nlf
Copy link
Contributor

@nlf nlf commented Dec 15, 2020

when running tests against nodejs v16.0.0-pre the existing test would fail, i tweaked the test so that it will work correctly for pre-release versions

@nlf nlf requested a review from a team as a code owner December 15, 2020 21:13
@npm-deploy-user
Copy link

angular-quickstart app-large app-medium ember-quickstart react-app
prev current status prev current status prev current status prev current status prev current status
initial install 41s 44.7s✅🐌 39.5s 47.8s🛑 34.5s 34.9s✅🐌 28.1s 30.3s✅🐌 33.5s 38.8s🛑
repeat install 9.6s 3.3s 8.6s 3.6s 8.3s 2.8s 7.7s 1.7s 9.1s 2.8s
with warm cache 32.3s 24.6s 33.8s 30.8s 31.3s 21.3s 23.4s 16.8s 29.1s 21.2s
with node_modules 9.2s 6.1s 8.6s 6s 9s 3.8s 7.8s 2.2s 9.4s 6.4s
with lockfile 32.6s 31.5s 31s 35.1s🛑 29s 21.8s 21.7s 18.9s 27.4s 27.2s
with warm cache and node_modules 9.3s 3.7s 7.9s 4.1s 8.4s 3.2s 7.6s 2s 9.2s 3.3s
with warm cache and lockfile 24.7s 10.7s 26.3s 13.8s 24.3s 8.4s 17.8s 7s 21.3s 8.2s
with node_modules and lockfile 10.1s 5.9s 9.8s 4.8s 8.6s 3.5s 7.8s 1.9s 9.7s 5.9s

@darcyclarke darcyclarke added Release 7.x work is associated with a specific npm 7 release release: next These items should be addressed in the next release labels Dec 16, 2020
Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

MylesBorins pushed a commit to MylesBorins/node that referenced this pull request Dec 16, 2020
nodejs-github-bot pushed a commit to nodejs/node that referenced this pull request Dec 17, 2020
Refs: npm/cli#2358

PR-URL: #36543
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruy Adorno <ruyadorno@github.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
isaacs pushed a commit that referenced this pull request Dec 18, 2020
@isaacs isaacs changed the base branch from latest to release/v7.3.0 December 18, 2020 19:19
@isaacs isaacs closed this Dec 18, 2020
targos pushed a commit to nodejs/node that referenced this pull request Dec 21, 2020
Refs: npm/cli#2358

PR-URL: #36543
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruy Adorno <ruyadorno@github.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@nlf nlf deleted the nlf/fix-doctor-tests branch March 28, 2022 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: next These items should be addressed in the next release Release 7.x work is associated with a specific npm 7 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants