Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: npm link <pkg> should not save package.json #2245

Closed
wants to merge 1 commit into from
Closed

fix: npm link <pkg> should not save package.json #2245

wants to merge 1 commit into from

Conversation

ruyadorno
Copy link
Contributor

When running npm link <pkg> it should not save the new item to the
currrent dependencies of that package.json file.

Fixes: #2034

@ruyadorno ruyadorno requested a review from a team as a code owner November 27, 2020 04:23
@ruyadorno ruyadorno added Release 7.x work is associated with a specific npm 7 release release: next These items should be addressed in the next release labels Nov 27, 2020
@ruyadorno ruyadorno self-assigned this Nov 27, 2020
@ruyadorno ruyadorno added this to the OSS - Sprint 20 milestone Nov 27, 2020
ljharb
ljharb reviewed Nov 27, 2020
View reviewed changes
Copy link
Contributor

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

However, if save/save/dev/save-peer is explicitly provided, it should save it. Does it with this PR?

@ruyadorno @darcyclarke
fix: npm link <pkg> should not save package.json
51d4666 
When running `npm link <pkg>` it should not save the new item to the
currrent dependencies of that package.json file.

Fixes: npm#2034

Co-authored-by: Darcy Clarke <darcy@darcyclarke.me>
@darcyclarke
Copy link
Contributor

@ljharb fixed this up so npm link will respect any save type/config passed.

@ruyadorno ruyadorno mentioned this pull request Nov 27, 2020
Merged
@ruyadorno ruyadorno closed this in 9c3413f Nov 27, 2020
@ruyadorno ruyadorno mentioned this pull request Nov 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb left review comments

@darcyclarke darcyclarke darcyclarke approved these changes

Assignees

@ruyadorno ruyadorno

Labels
release: next These items should be addressed in the next release Release 7.x work is associated with a specific npm 7 release
Projects
None yet
Milestone
OSS - Sprint 20
Development

Successfully merging this pull request may close these issues.

[BUG] npm link updates package.json to point to local directory
3 participants
@ruyadorno @darcyclarke @ljharb