Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests for cache command #2122

Closed
wants to merge 7 commits into from
Closed

tests for cache command #2122

wants to merge 7 commits into from

Conversation

nlf
Copy link
Contributor

@nlf nlf commented Nov 4, 2020

adds tests for the cache command, also fixes a subtle bug and adds verify to the completions

References

Closes npm/statusboard#143

@nlf nlf requested a review from a team as a code owner November 4, 2020 20:01
@nlf nlf force-pushed the nlf/cache-tests branch from 6a4191b to b49813e Compare November 4, 2020 20:21
@nlf nlf force-pushed the nlf/cache-tests branch from b49813e to 75928e3 Compare November 4, 2020 21:24
@nlf nlf force-pushed the nlf/cache-tests branch from c283943 to 13335d7 Compare November 4, 2020 22:23
isaacs
isaacs approved these changes Nov 4, 2020
View reviewed changes
Copy link
Contributor

@isaacs isaacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@darcyclarke darcyclarke added Release 7.x work is associated with a specific npm 7 release release: next These items should be addressed in the next release labels Nov 6, 2020
@isaacs isaacs closed this in 7046fe1 Nov 6, 2020
@darcyclarke darcyclarke mentioned this pull request Nov 13, 2020
Closed
@nlf nlf deleted the nlf/cache-tests branch March 28, 2022 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isaacs isaacs isaacs approved these changes

Assignees
No one assigned
Labels
release: next These items should be addressed in the next release Release 7.x work is associated with a specific npm 7 release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v7(tests): cache
3 participants
@nlf @isaacs @darcyclarke