From d02da52dc1ac6520223e9e7e8fdcbd9e27b5333f Mon Sep 17 00:00:00 2001 From: nlf Date: Tue, 7 Feb 2023 12:28:49 -0800 Subject: [PATCH] fix: revert `install-links` default back to `false` (#6142) this new default was unintentionally breaking so we are reverting it as a bug fix, see https://github.com/nodejs/node/issues/46542 --- lib/utils/config/definitions.js | 2 +- .../tap-snapshots/test/index.js.test.cjs | 2 +- .../test/lib/commands/config.js.test.cjs | 4 +-- tap-snapshots/test/lib/docs.js.test.cjs | 30 +++++++++---------- 4 files changed, 19 insertions(+), 19 deletions(-) diff --git a/lib/utils/config/definitions.js b/lib/utils/config/definitions.js index 578e0daa67737..77a88d79ae6e6 100644 --- a/lib/utils/config/definitions.js +++ b/lib/utils/config/definitions.js @@ -1078,7 +1078,7 @@ define('init.version', { }) define('install-links', { - default: true, + default: false, type: Boolean, description: ` When set file: protocol dependencies will be packed and installed as diff --git a/smoke-tests/tap-snapshots/test/index.js.test.cjs b/smoke-tests/tap-snapshots/test/index.js.test.cjs index 662c831160eb2..d5ce8b826be1e 100644 --- a/smoke-tests/tap-snapshots/test/index.js.test.cjs +++ b/smoke-tests/tap-snapshots/test/index.js.test.cjs @@ -61,7 +61,7 @@ npm ERR! [--global-style] [--omit [--omit [-w|--workspace ...]] -npm ERR! [-ws|--workspaces] [--include-workspace-root] [--no-install-links] +npm ERR! [-ws|--workspaces] [--include-workspace-root] [--install-links] npm ERR! npm ERR! aliases: clean-install, ic, install-clean, isntall-clean npm ERR! diff --git a/tap-snapshots/test/lib/commands/config.js.test.cjs b/tap-snapshots/test/lib/commands/config.js.test.cjs index 4170dd9078c86..43db223be31c5 100644 --- a/tap-snapshots/test/lib/commands/config.js.test.cjs +++ b/tap-snapshots/test/lib/commands/config.js.test.cjs @@ -81,7 +81,7 @@ exports[`test/lib/commands/config.js TAP config list --json > output matches sna "init.license": "ISC", "init.module": "{HOME}/.npm-init.js", "init.version": "1.0.0", - "install-links": true, + "install-links": false, "install-strategy": "hoisted", "key": null, "legacy-bundling": false, @@ -234,7 +234,7 @@ init.author.url = "" init.license = "ISC" init.module = "{HOME}/.npm-init.js" init.version = "1.0.0" -install-links = true +install-links = false install-strategy = "hoisted" json = false key = null diff --git a/tap-snapshots/test/lib/docs.js.test.cjs b/tap-snapshots/test/lib/docs.js.test.cjs index c882b320524c3..a4801df7470fe 100644 --- a/tap-snapshots/test/lib/docs.js.test.cjs +++ b/tap-snapshots/test/lib/docs.js.test.cjs @@ -1153,7 +1153,7 @@ number, if not already set in package.json. #### \`install-links\` -* Default: true +* Default: false * Type: Boolean When set file: protocol dependencies will be packed and installed as regular @@ -2537,7 +2537,7 @@ Options: [--omit [--omit ...]] [--foreground-scripts] [--ignore-scripts] [-w|--workspace [-w|--workspace ...]] -[-ws|--workspaces] [--include-workspace-root] [--no-install-links] +[-ws|--workspaces] [--include-workspace-root] [--install-links] Run "npm help audit" for more info @@ -2627,7 +2627,7 @@ Options: [--strict-peer-deps] [--no-package-lock] [--foreground-scripts] [--ignore-scripts] [--no-audit] [--no-bin-links] [--no-fund] [--dry-run] [-w|--workspace [-w|--workspace ...]] -[-ws|--workspaces] [--include-workspace-root] [--no-install-links] +[-ws|--workspaces] [--include-workspace-root] [--install-links] aliases: clean-install, ic, install-clean, isntall-clean @@ -2728,7 +2728,7 @@ Options: [--omit [--omit ...]] [--ignore-scripts] [--no-audit] [--no-bin-links] [--no-fund] [--dry-run] [-w|--workspace [-w|--workspace ...]] -[-ws|--workspaces] [--include-workspace-root] [--no-install-links] +[-ws|--workspaces] [--include-workspace-root] [--install-links] alias: ddp @@ -2999,7 +2999,7 @@ Options: [--omit [--omit ...]] [--ignore-scripts] [--no-audit] [--no-bin-links] [--no-fund] [-w|--workspace [-w|--workspace ...]] -[-ws|--workspaces] [--include-workspace-root] [--no-install-links] +[-ws|--workspaces] [--include-workspace-root] [--install-links] Run "npm help find-dupes" for more info @@ -3181,7 +3181,7 @@ Options: [--strict-peer-deps] [--no-package-lock] [--foreground-scripts] [--ignore-scripts] [--no-audit] [--no-bin-links] [--no-fund] [--dry-run] [-w|--workspace [-w|--workspace ...]] -[-ws|--workspaces] [--include-workspace-root] [--no-install-links] +[-ws|--workspaces] [--include-workspace-root] [--install-links] aliases: add, i, in, ins, inst, insta, instal, isnt, isnta, isntal, isntall @@ -3228,7 +3228,7 @@ Options: [--strict-peer-deps] [--no-package-lock] [--foreground-scripts] [--ignore-scripts] [--no-audit] [--no-bin-links] [--no-fund] [--dry-run] [-w|--workspace [-w|--workspace ...]] -[-ws|--workspaces] [--include-workspace-root] [--no-install-links] +[-ws|--workspaces] [--include-workspace-root] [--install-links] alias: cit @@ -3275,7 +3275,7 @@ Options: [--strict-peer-deps] [--no-package-lock] [--foreground-scripts] [--ignore-scripts] [--no-audit] [--no-bin-links] [--no-fund] [--dry-run] [-w|--workspace [-w|--workspace ...]] -[-ws|--workspaces] [--include-workspace-root] [--no-install-links] +[-ws|--workspaces] [--include-workspace-root] [--install-links] alias: it @@ -3322,7 +3322,7 @@ Options: [--omit [--omit ...]] [--ignore-scripts] [--no-audit] [--no-bin-links] [--no-fund] [--dry-run] [-w|--workspace [-w|--workspace ...]] -[-ws|--workspaces] [--include-workspace-root] [--no-install-links] +[-ws|--workspaces] [--include-workspace-root] [--install-links] alias: ln @@ -3365,7 +3365,7 @@ Options: [--omit [--omit ...]] [--link] [--package-lock-only] [--unicode] [-w|--workspace [-w|--workspace ...]] -[-ws|--workspaces] [--include-workspace-root] [--no-install-links] +[-ws|--workspaces] [--include-workspace-root] [--install-links] alias: la @@ -3447,7 +3447,7 @@ Options: [--omit [--omit ...]] [--link] [--package-lock-only] [--unicode] [-w|--workspace [-w|--workspace ...]] -[-ws|--workspaces] [--include-workspace-root] [--no-install-links] +[-ws|--workspaces] [--include-workspace-root] [--install-links] alias: list @@ -3717,7 +3717,7 @@ Options: [--omit [--omit ...]] [--dry-run] [--json] [--foreground-scripts] [--ignore-scripts] [-w|--workspace [-w|--workspace ...]] -[-ws|--workspaces] [--include-workspace-root] [--no-install-links] +[-ws|--workspaces] [--include-workspace-root] [--install-links] Run "npm help prune" for more info @@ -3794,7 +3794,7 @@ npm rebuild [] ...] Options: [-g|--global] [--no-bin-links] [--foreground-scripts] [--ignore-scripts] [-w|--workspace [-w|--workspace ...]] -[-ws|--workspaces] [--include-workspace-root] [--no-install-links] +[-ws|--workspaces] [--include-workspace-root] [--install-links] alias: rb @@ -4150,7 +4150,7 @@ npm uninstall [<@scope>/]... Options: [-S|--save|--no-save|--save-prod|--save-dev|--save-optional|--save-peer|--save-bundle] [-w|--workspace [-w|--workspace ...]] -[-ws|--workspaces] [--include-workspace-root] [--no-install-links] +[-ws|--workspaces] [--include-workspace-root] [--install-links] aliases: unlink, remove, rm, r, un @@ -4228,7 +4228,7 @@ Options: [--strict-peer-deps] [--no-package-lock] [--foreground-scripts] [--ignore-scripts] [--no-audit] [--no-bin-links] [--no-fund] [--dry-run] [-w|--workspace [-w|--workspace ...]] -[-ws|--workspaces] [--include-workspace-root] [--no-install-links] +[-ws|--workspaces] [--include-workspace-root] [--install-links] aliases: up, upgrade, udpate