Skip to content
This repository has been archived by the owner on Jan 20, 2022. It is now read-only.

[BUG] implement npm/rfcs#239 properly #147

Closed
isaacs opened this issue Sep 29, 2020 · 2 comments
Closed

[BUG] implement npm/rfcs#239 properly #147

isaacs opened this issue Sep 29, 2020 · 2 comments
Assignees
@isaacs
Labels
Bug thing that needs fixing
Milestone
OSS - Sprint 17

Comments

@isaacs
Copy link
Contributor

isaacs commented Sep 29, 2020

We don't currently catch peer dependency conflicts in 100% of cases, and sometimes throw when we should warn or warn when we should throw.
@ljharb
Copy link
Contributor

ljharb commented Sep 29, 2020

linking to npm/rfcs#239

@isaacs isaacs changed the title BUG: implement https://github.com/npm/rfcs/pull/239 properly BUG: implement npm/rfcs#239 properly Sep 30, 2020
@darcyclarke darcyclarke added this to the OSS - Sprint 18 milestone Oct 6, 2020
@darcyclarke darcyclarke added the Bug thing that needs fixing label Oct 6, 2020
@darcyclarke darcyclarke changed the title BUG: implement npm/rfcs#239 properly [BUG] implement npm/rfcs#239 properly Oct 6, 2020
@isaacs
Copy link
Contributor Author

isaacs commented Oct 13, 2020

Implemented and published as 1.0.0

@isaacs isaacs closed this as completed Oct 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isaacs isaacs

Labels
Bug thing that needs fixing
Projects
None yet
Milestone
OSS - Sprint 17
Development

No branches or pull requests
3 participants
@isaacs @ljharb @darcyclarke