-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notary v2: Prototype 2 Scope #53
Comments
What would the plan be for getting this upstreamed/accepted into the OCI distribution spec? This seems to jump ahead a bit from prototypes here to implementation by cloud providers.
Which signature format is this intended to use. I have some serious concerns with the existing one. I can't really find any of the discussion around its design, and it hasn't been touched in ~6 months. Could we include at least iterating on that format a bit here too? Same goes for payloads - the existing one looks like a mashup of a parts of a Descriptor and parts of a JWT token. We should pick one or the other here. Settling on the formats early will unblock other tools from integrating here.
Also, just a nit but an important one - I believe this isn't a spec yet - it's a spec draft. There are alternate proposals here too, including this one: opencontainers/image-spec#828. It's important that whatever tooling notary eventually works with whichever linking proposals are eventually accepted and implemented - not only this specific draft. |
I just read through the demo script - I'm having trouble seeing how the commands and examples support the requirements and threat models... Is there a better place to provide feedback or ask questions? I'm having a hard time understanding a lot of this. Apologies again if I missed something, I can't find any of the conversation that might have taken place on the PR itself before it was merged: notaryproject/notation#42 Was it discussed on a mailing list or something? The self-signed cert contains a CN entry of the registry the image is pushed to - doesn't this make the scenarios around moving content between registries difficult? The cert itself is kind of confusing, since it's self signed I can't follow what it adds on top of just a normal private key. Is the intention that these would be issued by some CA eventually? The CN/Subject stuff isn't clear to me. The SBOM example just contains a tag reference - should it instead reference the image by digest? I'm not following how the signature protects the mapping of this SBOM to the image. If we don't trust the registry operator, the scenarios from #48 might apply. The SBOM could be moved from one image to another by the registry and we have no way to be sure it's "attached" to the right one. |
@SteveLasker - I agree with @dlorenc - The prototype should call out that the this doesn't address the threat model issue like rollback and is aimed only at supporting storing artifacts and not its security aspects with the general direction or unifying with the prototype-3 which should address this problem. |
@sajayantony thanks, I agree. Clarifying exactly what threat model this prototype is intended to address would be useful. I'm still lost on the purpose of the self-signed certificate. |
|
Mostly finished wtih prototype-2
|
House cleaning as prototype-2 has been complete for a while, and we're working on the alpha1 release |
To support Notary v2 requirements for multiple signatures that don't change the artifact digest or tag, we must support new artifacts that link to existing artifacts.
Goals & Intent
With Prototype-1 complete, we must now harden the linked artifacts implementation with a spec and design that could be deployed for production validation. While the design will be prototyped in CNCF Distribution, the full implementation will not be completed in CNCF Distribution. Cloud providers have cloud-optimized implementations, and implementers of CNCF Distribution have their unique product implementations. The purpose of the prototype is to prove the APIs are capable of being implemented.
The prototype should:
oci.artifact.manifest
with the link, discovering and pulling of artifacts, using the OCI.artifact.manifestORAS cli to support pushing by digest, enabling the ability to update an existing tag, after the updated image and signatures have been posted.(needs further refactoring not related to notary efforts)docker sign, verify push, pull
capabilities, supporting theoci.artifact.manifest
and linked manifest discovery.With ORAS support, users should be able to link Notary v2 signatures or other files, including SBoM simulated files. ORAS push, would push the single file reference as a tar file, eliminating theSee oras issue # 114 (needs further refactoring not related to notary efforts)org.opencontainers.image.title
annotation.Update the docker-generate plug-in to support pushing the image by digest, the linked signature, then pushing the tag update.(needs further refactoring not related to notary efforts)The prototype should not:
Target Experience
The experience should focus on the e2e tooling, including the use of the docker cli.
Demo Script
Deliverables
The text was updated successfully, but these errors were encountered: