Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve error message for --signature-format flag #925

Merged
merged 7 commits into from
Apr 18, 2024
Merged

fix: improve error message for --signature-format flag #925

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
689006e
fix: improve error message for --signature-format flag
JeyJeyGao Apr 9, 2024
8e98706
fix: update error message
JeyJeyGao Apr 10, 2024
584ea42
fix: improve test coverage
JeyJeyGao Apr 10, 2024
4617be1
test: improve e2e
JeyJeyGao Apr 10, 2024
b6828aa
test: improve e2e test
JeyJeyGao Apr 10, 2024
ca8ad88
fix: update script
JeyJeyGao Apr 10, 2024
9facfa5
test: improve e2e test
JeyJeyGao Apr 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/envelope/envelope.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ func GetEnvelopeMediaType(sigFormat string) (string, error) {
case COSE:
return cose.MediaTypeEnvelope, nil
}
return "", fmt.Errorf("signature format %q not supported", sigFormat)
return "", fmt.Errorf("signature format %q not supported\nSupported signature envelope formats are \"jws\" and \"cose\"", sigFormat)
}

// ValidatePayloadContentType validates signature payload's content type.
Expand Down
Loading