Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vote for release of notation v1.0.0-rc.6 #686

Closed
6 tasks done
priteshbandi opened this issue May 25, 2023 · 10 comments
Closed
6 tasks done

Vote for release of notation v1.0.0-rc.6 #686

priteshbandi opened this issue May 25, 2023 · 10 comments

Comments

@priteshbandi
Copy link
Contributor

priteshbandi commented May 25, 2023

We need 4 approvals from the current 6 maintainers to vote for tagging cc3f7aa as v1.0.0-rc.6. Here is the link to change log .


change log for v1.0.0-rc6

@priteshbandi priteshbandi added bug Something isn't working triage Need to triage labels May 25, 2023
@priteshbandi priteshbandi changed the title [NOT READY]Vote for release of notation v1.0.0-rc.6 [NOT READY] Vote for release of notation v1.0.0-rc.6 May 25, 2023
@priteshbandi priteshbandi changed the title [NOT READY] Vote for release of notation v1.0.0-rc.6 Vote for release of notation v1.0.0-rc.6 May 26, 2023
@yizha1
Copy link
Contributor

yizha1 commented May 26, 2023

LGTM but IANAM

@Two-Hearts
Copy link
Contributor

LGTM

1 similar comment
@JeyJeyGao
Copy link
Contributor

LGTM

@FeynmanZhou
Copy link
Member

Support +1

@shizhMSFT
Copy link
Contributor

LGTM

1 similar comment
@rgnote
Copy link
Contributor

rgnote commented May 26, 2023

LGTM

@shizhMSFT
Copy link
Contributor

The build for cc3f7aa was failed.

@shizhMSFT
Copy link
Contributor

The E2E test has been fixed by #690. Since the fix only applies to the e2e test, we can continue to release v1.0.0-rc.6.

@gokarnm
Copy link
Contributor

gokarnm commented May 26, 2023

LGTM

@FeynmanZhou FeynmanZhou removed bug Something isn't working triage Need to triage labels May 26, 2023
@priteshbandi
Copy link
Contributor Author

RC6 is released https://github.com/notaryproject/notation/releases/tag/v1.0.0-rc.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

8 participants