From 77278ff73f6c18d6437f68c989acae1f88287964 Mon Sep 17 00:00:00 2001 From: Junjie Gao Date: Tue, 14 Jan 2025 09:06:05 +0000 Subject: [PATCH] fix: resolve comments Signed-off-by: Junjie Gao --- internal/cmd/flags.go | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/internal/cmd/flags.go b/internal/cmd/flags.go index 196768b2c..a2bed995b 100644 --- a/internal/cmd/flags.go +++ b/internal/cmd/flags.go @@ -44,14 +44,14 @@ var ( Usage: "signature envelope format, options: \"jws\", \"cose\"", } SetPflagSignatureFormat = func(fs *pflag.FlagSet, p *string) { - defaultSignatureFormat := envelope.JWS - // load config to get signatureFormat config, err := configutil.LoadConfigOnce() - if err == nil && config.SignatureFormat != "" { - defaultSignatureFormat = config.SignatureFormat + if err != nil || config.SignatureFormat == "" { + fs.StringVar(p, PflagSignatureFormat.Name, envelope.JWS, PflagSignatureFormat.Usage) + return } - fs.StringVar(p, PflagSignatureFormat.Name, defaultSignatureFormat, PflagSignatureFormat.Usage) + // set signatureFormat from config + fs.StringVar(p, PflagSignatureFormat.Name, config.SignatureFormat, PflagSignatureFormat.Usage) } PflagID = &pflag.Flag{