Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oras-go updated v2.3.0 #346

Closed
JeyJeyGao opened this issue Aug 30, 2023 · 0 comments · Fixed by #347
Closed

oras-go updated v2.3.0 #346

JeyJeyGao opened this issue Aug 30, 2023 · 0 comments · Fixed by #347
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@JeyJeyGao
Copy link
Contributor

Is your feature request related to a problem?

We need to update to oras-go v2.3.0 and apply new feature oras.PackManifest

What solution do you propose?

update to oras-go v2.3.0

What alternatives have you considered?

No

Any additional context?

No response

@JeyJeyGao JeyJeyGao added enhancement New feature or request triage Needs evaluation for feasibility, timeline, etc. labels Aug 30, 2023
@JeyJeyGao JeyJeyGao self-assigned this Aug 30, 2023
@yizha1 yizha1 removed the triage Needs evaluation for feasibility, timeline, etc. label Sep 12, 2023
@yizha1 yizha1 added this to the 1.1.0 milestone Sep 12, 2023
JeyJeyGao added a commit that referenced this issue Sep 15, 2023
- Update oras-go to v2.3.0.
- Replace oras.Pack() with oras.PackManifest() as it is deprecated in
v2.3.0.
- Generate an empty config blob manually, as oras.PackManifest() does
not generate the config blob with the notation artifact type as the
media type.

Resolves #346 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

---------

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Two-Hearts pushed a commit to Two-Hearts/notation-go that referenced this issue Sep 18, 2023
- Update oras-go to v2.3.0.
- Replace oras.Pack() with oras.PackManifest() as it is deprecated in
v2.3.0.
- Generate an empty config blob manually, as oras.PackManifest() does
not generate the config blob with the notation artifact type as the
media type.

Resolves notaryproject#346
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

---------

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants