chore: invalid signing time prompt improvement #173
Conversation
Signed-off-by: fandu <dufann@hotmail.com> Signed-off-by: fanndu <dufann@hotmail.com>
…k license (notaryproject#154) Signed-off-by: fanndu <dufann@hotmail.com>
…oject#153) Signed-off-by: fanndu <dufann@hotmail.com>
fanndu
requested review from
gokarnm,
JeyJeyGao,
justincormack,
NiazFK,
priteshbandi,
rgnote,
shizhMSFT,
SteveLasker and
Two-Hearts
as code owners
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #173 +/- ##
==========================================
+ Coverage 89.28% 89.32% +0.03%
==========================================
Files 21 21
Lines 1718 1724 +6
==========================================
+ Hits 1534 1540 +6
Misses 149 149
Partials 35 35 ☔ View full report in Codecov by Sentry. |
shizhMSFT
changed the title
shizhMSFT
changed the title
|
@fanndu this branch is out-of-date with the base branch. Maybe you need to fix it. |
|
Signed-off-by: fanndu <dufann@hotmail.com>
…oject#172) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Thanks. Already fix it. |
|
@priteshbandi @patrickzheng200 Would you mind reviewing this PR again? Thanks. |
|
@fanndu I'm trying to merge this PR. Could you rebase the branch? |
Done. Thanks. |
fix: notaryproject/notation#829
Display the validity period of the certificate when the signing time is invalid.
./bin/notation sign localhost:5000/gateway@sha256:b992672d71a62c0a94cd8640f7c0db62ffb9de65317100742bf44892b179445f Error: certificate-chain is invalid, certificate with subject "CN=test,O=Notary,L=Seattle,ST=WA,C=US" was invalid at signing time of 2023-11-12 08:33:33 +0000 UTC. Valid signing time from [2023-10-25 02:40:40 +0000 UTC] to [2023-10-26 02:40:40 +0000 UTC]