Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: shift Go support window to [1.19, 1.20] #135

Merged
merged 2 commits into from
Apr 5, 2023

Conversation

kody-kimberl
Copy link
Contributor

Updates go.mod and the GitHub actions to shift window from [1.18, 1.19] to [1.19,1.20]

Confirmed that unit tests work for 1.20

Resolves #115

Signed-off-by: Kody Kimberl kody.kimberl.work@gmail.com

Signed-off-by: Kody Kimberl <kody.kimberl.work@gmail.com>
@shizhMSFT
Copy link
Contributor

@kody-kimberl 1.20 requires quotes to be a string "1.20" in yaml . Otherwise, it will be recognized as the number 1.2.

Signed-off-by: Kody Kimberl <kody.kimberl.work@gmail.com>
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-advanced-security
Copy link

You have successfully added a new CodeQL configuration .github/workflows/codeql.yml:analyze/go-version:1.20. As part of the setup process, we have scanned this repository and found 1 existing alert. Please check the repository Security tab to see all alerts.

@codecov-commenter
Copy link

Codecov Report

Merging #135 (51e9a2a) into main (beeb17a) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main     #135   +/-   ##
=======================================
  Coverage   90.32%   90.32%           
=======================================
  Files          16       16           
  Lines        1457     1457           
=======================================
  Hits         1316     1316           
  Misses        110      110           
  Partials       31       31           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT changed the title feat: shift Go support window to [1.19, 1.20] bump: shift Go support window to [1.19, 1.20] Apr 3, 2023
@shizhMSFT shizhMSFT changed the title bump: shift Go support window to [1.19, 1.20] build: shift Go support window to [1.19, 1.20] Apr 3, 2023
Copy link
Contributor

@rgnote rgnote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shift Go Support Window to [1.19, 1.20]
5 participants