Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirm go-cose v1.0.0-rc.1 is ready for a 1.0.0 release #37

Closed
SteveLasker opened this issue Aug 12, 2022 · 9 comments
Closed

Confirm go-cose v1.0.0-rc.1 is ready for a 1.0.0 release #37

SteveLasker opened this issue Aug 12, 2022 · 9 comments
Assignees

Comments

@SteveLasker
Copy link
Contributor

SteveLasker commented Aug 12, 2022

The go-cose project is pending a 1.0.0 release
Before cutting the release, they (me) are asking for dependent projects to confirm confidence in the current 1.0.0-rc.1 release before cutting the 1.0.0 release.

Have we completed our testing for notary cose support? Once we have, we would add a +1 from notary on the Create 1.0.0 Release #98 issue

@shizhMSFT
Copy link
Contributor

@SteveLasker We are building and testing COSE support for notation, which can be tracked at

@SteveLasker
Copy link
Contributor Author

SteveLasker commented Aug 12, 2022

@shizhMSFT, excellent! As we get cose integrated in a notation build, we'll start having users validate MAR content. At that point, we should have good validation.
Or, do you think the test cases above have covered enough validation that you're confident in releasing go-cose 1.0?

We're doing our best to not release 1.0, then have a 1.1 release because folks hadn't fully tested the rc.1 release.

@shizhMSFT
Copy link
Contributor

@SteveLasker Let's release go-cose 1.0 after merging the COSE support for notation.

/cc @yizha1 @FeynmanZhou

@yizha1
Copy link
Contributor

yizha1 commented Aug 15, 2022

Once COSE support is merged into notation main branch, we could invite users to verify it for an E2E flow. Based on the results we will be more confident on go-cose 1.0 release.

@shizhMSFT
Copy link
Contributor

@SteveLasker Can we cut a v1.0.0-rc.2 version for go-cose?

@FeynmanZhou
Copy link
Member

go-cose v1.0.0-rc.2 is available: https://github.com/veraison/go-cose/releases/tag/v1.0.0-rc.2. I think we can start to update the dependency version of go-cose to v1.0.0-rc.2 here.

@shizhMSFT
Copy link
Contributor

I think go-cose v1.0.0-rc.2 is good enough for a go-cose v1.0.0 release to be consumed by notation.

@fanndu
Copy link
Contributor

fanndu commented Aug 15, 2023

@SteveLasker The go-cose v1.1.0 is already supported, so this Issues should be closed.
require ( github.com/fxamacker/cbor/v2 v2.4.0 github.com/golang-jwt/jwt/v4 v4.5.0 github.com/veraison/go-cose v1.1.0 golang.org/x/crypto v0.11.0 )
go.mod

@yizha1
Copy link
Contributor

yizha1 commented Sep 18, 2023

Thanks @fanndu Closed as https://github.com/veraison/go-cose/releases/tag/v1.1.0 was released

@yizha1 yizha1 closed this as completed Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants