-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update registry authentication with cred store #279
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zr-msft
requested review from
FeynmanZhou,
NiazFK,
iamsamirzon,
justincormack,
priteshbandi,
SteveLasker,
toddysm,
vaninrao10 and
yizha1
as code owners
June 7, 2023 20:30
✅ Deploy Preview for notarydev ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
@yizha1 left a question in the issue as well. reposting here: can you provide the following config example snippets:
Current examples in the doc were my best guess. |
zr-msft
force-pushed
the
issue-276
branch
2 times, most recently
from
June 12, 2023 16:11
6f021b1
to
3d3826d
Compare
Two-Hearts
reviewed
Jun 15, 2023
iamsamirzon
requested changes
Jun 15, 2023
Signed-off-by: Zach Rhoads <zachary.rhoads@microsoft.com>
iamsamirzon
approved these changes
Jun 19, 2023
LGTM |
yizha1
approved these changes
Jun 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thanks @zr-msft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #276