changefeed: error with 400 for nonexistent change_id #1264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Riyaz Faizullabhoy <riyaz.faizullabhoy@docker.com>
|
I always figured the fix for this would be to default the change ID at the handler/input verification level, rather than erroring when not provided. |
|
@endophage: that works too. Do you think |
|
Yeah, and I also have a strong preference for making Go's "zero" values the defaults whenever possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check early that the
change_idparameter exists for rethinkdb instead of returning a 500 on a query error.Closes #1257
Signed-off-by: Riyaz Faizullabhoy riyaz.faizullabhoy@docker.com