Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force go networking instead of cgo for cross and static builds #1039

Merged
merged 1 commit into from
Dec 23, 2016

Conversation

riyazdf
Copy link
Contributor

@riyazdf riyazdf commented Nov 16, 2016

Identical fix to #1038 if we wanted to include it in a v0.4.3 release. Set up on a hotfix/0.4.3 branch

Signed-off-by: Riyaz Faizullabhoy riyaz.faizullabhoy@docker.com

@riyazdf
Copy link
Contributor Author

riyazdf commented Nov 16, 2016

CircleCI will fail only on container 4 during the $ buildscripts/circle_parallelism.sh (4) due to golang lint updates -- I'd prefer not to keep them in this PR to minimize code changes for this hotfix.

The rest of the tests pass, and here's an example output from make cross's linux client to show the fix works:

# ./notary version
notary
 Version:    0.4.3
 Git commit: 485d5e1
# ./notary -D list test-repo
DEBU[0000] Configuration file not found, using defaults
DEBU[0000] Using the following trust directory: /root/.notary
ERRO[0000] could not reach https://notary-server:4443: Get https://notary-server:4443/v2/: dial tcp: lookup notary-server on 8.8.8.8:53: no such host
INFO[0000] continuing in offline mode
DEBU[0000] No yubikey found, using alternative key storage: no library found

* fatal: client is offline

Copy link
Contributor

@endophage endophage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyli
Copy link
Contributor

cyli commented Dec 21, 2016

LGTM

Signed-off-by: Riyaz Faizullabhoy <riyaz.faizullabhoy@docker.com>
@riyazdf riyazdf merged commit 98ad8fa into hotfix/0.4.3 Dec 23, 2016
@riyazdf riyazdf deleted the force-go-networking branch December 23, 2016 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants