Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIP 47 using deprecated NIP 04 for encryption #1639

Closed
Gudnessuche opened this issue Dec 9, 2024 · 7 comments
Closed

NIP 47 using deprecated NIP 04 for encryption #1639

Gudnessuche opened this issue Dec 9, 2024 · 7 comments

Comments

@Gudnessuche
Copy link
Contributor

Is it prudent to move to NIP 17 or NIP 44 for encryption, giving that NIP 04 leaks meta data?

@vitorpamplona
Copy link
Collaborator

Already happening: #1531

@staab staab closed this as completed Dec 9, 2024
@staab staab reopened this Dec 9, 2024
@staab staab closed this as completed Dec 9, 2024
@Gudnessuche
Copy link
Contributor Author

@vitorpamplona why has this not been merged?

@vitorpamplona
Copy link
Collaborator

As always, we need 2+ implementations to catch up to it before the merge.

@Gudnessuche
Copy link
Contributor Author

Alby says they implement this, doesn't Amethyst use nip 44 as well?
Boardwalkcash also uses itI suppose.
Nostrudel?

@vitorpamplona
Copy link
Collaborator

vitorpamplona commented Dec 9, 2024

Not as they wrote. We dynamically pick if it is NIP-04 or NIP-44 by the contents and not by the v tag. But because this is such a breaking change, we might need to wait for more apps to be ready before merging

@Gudnessuche
Copy link
Contributor Author

Given this is a security risk, wouldn't you rather we prioritized security?
Your PR looks fantastic to go imo.

@vitorpamplona
Copy link
Collaborator

I wouldn't call it a security risk...

But regardless of what it is, the NIP repo is a reflection of reality as opposed to an imposer of reality. We need lots of people to adopt specifications/changes before things get merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants