Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename theme file to enable theme development features #148

Closed
arcticicestudio opened this issue Jul 21, 2019 · 0 comments
Closed

Rename theme file to enable theme development features #148

arcticicestudio opened this issue Jul 21, 2019 · 0 comments

Comments

@arcticicestudio
Copy link
Contributor

arcticicestudio commented Jul 21, 2019

Extracted from #143 submitted by @svipas

An undocumented feature for theme extension developers is to ensure the name of the JSON file is suffixed with -color-theme.json. This enables the JSON scheme validation for the theme API allowing developers to validate the implemented theme keys, showing warnings about deprecated keys and providing full auto completion, field documentations and color previews (color picker) for the HEX format.
This change aligns Nord to the official bundled and default themes by adapting to the naming scheme without being a breaking change since the theme is identified by it's extension ID as well as the _metadata field in the package.json and not by the name of the theme file (which would be odd since a theme can provide multiple theme files).

@arcticicestudio arcticicestudio added this to the Next milestone Jul 21, 2019
@arcticicestudio arcticicestudio self-assigned this Jul 21, 2019
@arcticicestudio arcticicestudio changed the title Rename theme file to enable JSON theme scheme validation Rename theme file to enable theme development features Jul 21, 2019
@arcticicestudio arcticicestudio removed their assignment Jul 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant