This plugin breaks ionic restore

[ptarjan]

If I have cordova-hot-code-push-plugin in my cordovaPlugins section of my package.json and then run

ionic restore

it hangs during this plugin's step.

[nikDemyankov]

Thanks, I'll check it.

[nikDemyankov]

It hangs if cordova-hot-code-push-cli client is not yet installed. When you install the plugin - it asks you, if you would like to install the CLI client as well. But ionic state restore suppresses all output/input requests from the dependency modules. So, after plugin is installed - the question is asked and script waits for your answer, but it is not shown because of Ionic.

Probable solution would be to remove installation request from the plugin. It will also solve the issue #8. But it will be less convenient...

[ptarjan]

Well, your extra convenience is making me not use your plugin sadly, so I would recommend removing it.

[nikDemyankov]

Whatever is best for you :) I think similar issue will acquire with any plugin, that requires input from the user.

Either way, because of that we, probably, will change installation process. Luckily, it's easy to do. So instead of asking user if he want to install CLI client as well - we will just post message about that and that's it. User will have to do it like so:

npm install cordova-hot-code-push-cli

[ptarjan]

would you need to have a -g on that npm command or will a locally installed cli be ok?

[nikDemyankov]

Depends on what you want.

You can use it locally. In that case, if it's installed as local module in the project's root folder, then you'll have to call it like so:

node_modules/cordova-hot-code-push-cli/bin/cordova-hcp build

In the case of the -g it is easier:

cordova-hcp server

Plus, if plugin is used in several projects and CLI is installed globally - you don't have to install it again. So I would use -g. Probably, will update docs on CLI to recommend to use -g.

[ptarjan]

Your detection scripts currently require a -g install which is why I was asking.

[nikDemyankov]

Updated installation hook - no more user input requests for CLI client. ionic state restore will not hang. Issue will be closed after the release.

[ptarjan]

yay, thanks! I'd be in favor of a release as soon as this round of my bugs are closed :)

[nikDemyankov]

Fixed in version 1.0.3