Skip to content
This repository has been archived by the owner on Oct 1, 2018. It is now read-only.

Could not use link mode of cordova plugin. #10

Closed
robario opened this issue Jun 20, 2016 · 3 comments
Closed

Could not use link mode of cordova plugin. #10

robario opened this issue Jun 20, 2016 · 3 comments

Comments

@robario
Copy link
Contributor

robario commented Jun 20, 2016

When using symlink to install this plugin

$ cordova plugin add --link ./node_modules/cordova-hot-code-push-local-dev-addon

It modify ./node_modules/cordova-hot-code-push-local-dev-addon/src/ios/HCPLDPlugin.h
not ./platforms/ios/*/Plugins/cordova-hot-code-push-local-dev-addon/HCPLDPlugin.h.

In other words, this plugin modify ./plugins/cordova-hot-code-push-local-dev-addon/src/ios/HCPLDPlugin.h.

I think a plugin should not modify itself.
It should only modify the under ./platforms/ instead.

@nikDemyankov
Copy link
Member

It doesn't. It modifies only platform's version and not the source: https://github.com/nordnet/cordova-hot-code-push-local-dev-addon/blob/master/scripts/lib/swiftHelper.js#L181 .

So my guess that there's something wrong with symlinking.

@robario
Copy link
Contributor Author

robario commented Jun 21, 2016

Certainly...
I show the difference between using link mode and not link mode.

  • OS X El Capitan.
  • cordova@6.2.0
  • cordova-ios@4.1.1
  • cordova-hot-code-push-local-dev-addon@0.2.2
  • cordova-hot-code-push-plugin@1.3.2
  • cordova-hot-code-push-cli@1.1.1
node_modules :: ./node_modules/cordova-hot-code-push-local-dev-addon/src/ios/HCPLDPlugin.h
     plugins :: ./plugins/cordova-hot-code-push-local-dev-addon/src/ios/HCPLDPlugin.h
   platforms :: ./platforms/cordova-hot-code-push-local-dev-addon/HCPLDPlugin.h

without link mode

$ cordova plugin add cordova-hot-code-push-local-dev-addon

in node_modules:1: //
in      plugins:1: //
in    platforms:1: //

$ cordova prepare ios

in node_modules:1: //
in      plugins:1: //
in    platforms:1: #import "MYPRODUCT-Swift.h"

with link mode

$ cordova plugin add --link ./node_modules/cordova-hot-code-push-local-dev-addon

in node_modules:1: //
in      plugins:1: //
in    platforms:1: //

$ cordova prepare ios

in node_modules:1: #import "MYPRODUCT-Swift.h"
in      plugins:1: #import "MYPRODUCT-Swift.h"
in    platforms:1: #import "MYPRODUCT-Swift.h"

@nordnet-deprecation-bot
Copy link
Contributor

👋 Hi! Thank you for your interest in this repo.

😢 We are not using nordnet/cordova-hot-code-push-local-dev-addon anymore, and we lack the manpower and the experience needed to maintain it. We are aware of the inconveniece that this may cause you. Feel free to use it as is, or create your own fork.

🔒 This will now be closed & locked.

ℹ️ Please see #29 for more information.

@nordnet nordnet locked and limited conversation to collaborators Sep 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants