Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow indexed_field is none for image datasets with create_index #315

Merged
merged 4 commits into from
Jul 10, 2024

Conversation

zanussbaum
Copy link
Collaborator

@zanussbaum zanussbaum commented Jul 10, 2024

when using add_data with the create_index flow, we need to allow a None for indexed_field and default to a fixed value for now for native image datasets


🚀 This description was created by Ellipsis for commit cde7192

Summary:

Allow None for indexed_field in image datasets, defaulting to _blob_hash, and update version to 3.0.38.

Key points:

  • Allow None for indexed_field in image datasets, defaulting to _blob_hash.
  • Update version to 3.0.38.
  • Updated examples/image/map_cifar10.py to remove unused import and add data parameter in atlas.map_data call.
  • Modified nomic/dataset.py::AtlasDataset::create_index:
    • Set indexed_field to _blob_hash for image datasets if indexed_field is None.
    • Log a warning if indexed_field is not None for image datasets.
  • Modified nomic/atlas.py::map_data to allow None for indexed_field in image datasets, defaulting to _blob_hash.
  • Updated version in setup.py from 3.0.36 to 3.0.38.

Generated with ❤️ by ellipsis.dev

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Reviewed everything up to 6a3db3b in 43 seconds

More details
  • Looked at 53 lines of code in 3 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_2oq09IxwyBSLle8W


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

nomic/dataset.py Show resolved Hide resolved
@AndriyMulyar
Copy link
Contributor

approved but commits are failing

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Incremental review on cde7192 in 1 minute and 8 seconds

More details
  • Looked at 12 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_cq5rJVS1X5VMt3OD


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

nomic/atlas.py Show resolved Hide resolved
@zanussbaum zanussbaum changed the title fix: allow create_index is none for image datasets fix: allow indexed_field is none for image datasets with create_index Jul 10, 2024
@zanussbaum zanussbaum merged commit 2d7d2da into main Jul 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants