-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: allow indexed_field is none for image datasets with create_index
#315
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested. Reviewed everything up to 6a3db3b in 43 seconds
More details
- Looked at
53
lines of code in3
files - Skipped
0
files when reviewing. - Skipped posting
0
drafted comments based on config settings.
Workflow ID: wflow_2oq09IxwyBSLle8W
Want Ellipsis to fix these issues? Tag @ellipsis-dev
in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
approved but commits are failing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested. Incremental review on cde7192 in 1 minute and 8 seconds
More details
- Looked at
12
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
0
drafted comments based on config settings.
Workflow ID: wflow_cq5rJVS1X5VMt3OD
Want Ellipsis to fix these issues? Tag @ellipsis-dev
in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
create_index
when using
add_data
with thecreate_index
flow, we need to allow a None forindexed_field
and default to a fixed value for now for native image datasetsSummary:
Allow
None
forindexed_field
in image datasets, defaulting to_blob_hash
, and update version to3.0.38
.Key points:
None
forindexed_field
in image datasets, defaulting to_blob_hash
.3.0.38
.examples/image/map_cifar10.py
to remove unused import and adddata
parameter inatlas.map_data
call.nomic/dataset.py::AtlasDataset::create_index
:indexed_field
to_blob_hash
for image datasets ifindexed_field
isNone
.indexed_field
is notNone
for image datasets.nomic/atlas.py::map_data
to allowNone
forindexed_field
in image datasets, defaulting to_blob_hash
.setup.py
from3.0.36
to3.0.38
.Generated with ❤️ by ellipsis.dev