From 2875a35bb0fcb41f7d7934130d42385cb1a543e8 Mon Sep 17 00:00:00 2001 From: Lockwarr Date: Thu, 1 Feb 2024 10:26:41 +0200 Subject: [PATCH] docs: lint errors and adr update --- doc/adr/20231215-accept-fees-in-foreign-denoms.md | 4 ---- x/tax/keeper/custom_tx_fee_checker_test.go | 4 ++-- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/doc/adr/20231215-accept-fees-in-foreign-denoms.md b/doc/adr/20231215-accept-fees-in-foreign-denoms.md index de15c646..4b54157f 100644 --- a/doc/adr/20231215-accept-fees-in-foreign-denoms.md +++ b/doc/adr/20231215-accept-fees-in-foreign-denoms.md @@ -36,10 +36,6 @@ message DenomTicker { For each DEX that we work with, there will be a separate oracle and profit addresses. The denoms that we want to accept as fees will be defined for each DEX. For example, ATOM transferred from dex1 to nolus will have one denom, and ATOM transferred from dex2 to nolus will have another denom. The custom txFeeChecker will compare the denom that the user paid with the accepted denoms. When there is a match, we will know which oracle to query for the price. The deducted tax, not paid in the base asset, will be sent to the corresponding profit address from the parameters configuration. -For each dex that we work with, there will be a separate oracle and profit addresses.The denoms that we want to accept as fees will be defined for each dex. -For example, ATOM transferred from dex1 to nolus will have one denom, and ATOM transferred from dex2 to nolus will have another denom. The custom txFeeChecker will compare the denom that the user paid with the accepted denoms. When there is a match, we will know which oracle to query for the price. The deducted tax, not paid in the base asset, will be sent to the corresponding profit address from the parameters configuration. - - ### Positive Consequences - Easier Onboarding for New Users: New users can participate in the nolus network without the necessity to acquire NLS initially. This reduces the barrier to entry and encourages experimentation with the protocol using existing funds. diff --git a/x/tax/keeper/custom_tx_fee_checker_test.go b/x/tax/keeper/custom_tx_fee_checker_test.go index aa01cb41..9ccad9c1 100644 --- a/x/tax/keeper/custom_tx_fee_checker_test.go +++ b/x/tax/keeper/custom_tx_fee_checker_test.go @@ -59,7 +59,7 @@ func TestCustomTxFeeCheckerSuccessfulInUsdc(t *testing.T) { require.Equal(t, sdk.NewCoins(sdk.NewInt64Coin(osmoAxlUSDCDenom, feeAmount)), feeCoins) } -// Fail to pay fees in ibc/5DE... which represents axlUSDC from osmosis. Minimum gas prices set to unls. High gas -> fee amount not enough +// Fail to pay fees in ibc/5DE... which represents axlUSDC from osmosis. Minimum gas prices set to unls. High gas -> fee amount not enough. func TestCustomTxFeeCheckerFailDueToHighGasPayingWithUSDC(t *testing.T) { taxKeeper, ctx, mockWasmKeeper := keepertest.TaxKeeper(t, true, sdk.DecCoins{sdk.NewDecCoin("unls", sdk.NewInt(1))}) // create a new CustomTxFeeChecker @@ -79,7 +79,7 @@ func TestCustomTxFeeCheckerFailDueToHighGasPayingWithUSDC(t *testing.T) { require.Equal(t, "insufficient fees; got: 1.000000ibc/5DE4FCAF68AE40F81F738C857C0D95F7C1BC47B00FA1026E85C1DD92524D4A11 required: 5226075.194079ibc/5DE4FCAF68AE40F81F738C857C0D95F7C1BC47B00FA1026E85C1DD92524D4A11: insufficient fee", err.Error()) } -// Fail to pay fees in ibc/C4C... which represents OSMO. Minimum gas prices set to unls. High gas -> fee amount not enough +// Fail to pay fees in ibc/C4C... which represents OSMO. Minimum gas prices set to unls. High gas -> fee amount not enough. func TestCustomTxFeeCheckerFailDueToHighGasPayingWithOSMO(t *testing.T) { taxKeeper, ctx, mockWasmKeeper := keepertest.TaxKeeper(t, true, sdk.DecCoins{sdk.NewDecCoin("unls", sdk.NewInt(1))}) // create a new CustomTxFeeChecker