Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "enabled" parameter of Virtual Slides and Free Mode #5688

Closed
3 of 4 tasks
DAnn2012 opened this issue May 1, 2022 · 1 comment · Fixed by #5702
Closed
3 of 4 tasks

The "enabled" parameter of Virtual Slides and Free Mode #5688

DAnn2012 opened this issue May 1, 2022 · 1 comment · Fixed by #5702

Comments

@DAnn2012
Copy link
Contributor

DAnn2012 commented May 1, 2022

Clear and concise description of the problem

In the .d.ts files, the "enabled" parameter of Virtual Slides and Free Mode has no default value and description

export interface FreeModeOptions {
enabled?: boolean;

export interface VirtualOptions {
enabled?: boolean;

Suggested solution

Add the default value and description for the "enabled" parameter of Virtual Slides and Free Mode in the .d.ts files

Alternative

No response

Additional context

No response

Validations

  • Follow our Code of Conduct
  • Read the docs.
  • Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

Would you like to open a PR for this feature?

  • I'm willing to open a PR
@DAnn2012
Copy link
Contributor Author

DAnn2012 commented May 5, 2022

Also, the "enabled" parameter of Lazy Loading in the .d.ts file does not have the default value

export interface LazyOptions {
/**
* Whether the lazy loading images is enabled
*/
enabled?: boolean;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant