Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with 8.4.0 due to PR #5954 #6064

Closed
6 tasks done
fiveable-jferg opened this issue Sep 14, 2022 · 3 comments
Closed
6 tasks done

Issue with 8.4.0 due to PR #5954 #6064

fiveable-jferg opened this issue Sep 14, 2022 · 3 comments

Comments

@fiveable-jferg
Copy link

Check that this is really a bug

  • I confirm

Reproduction link

Will create a repro if needed.

Bug description

The code in https://github.com/nolimits4web/swiper/pull/5954/files#diff-88a223b4c7649642379e3d1da5338dc2432bbe32b5787cfcda0b484fce3e3786 is causing me issues because there is a circumstance where displayName is null, and since there is no check for && child.type.displayName in the if statement, I'm getting a Cannot read property 'includes' of undefined when that situation is encountered.

Expected Behavior

Check succeeds without error.

Actual Behavior

TypeError: Cannot read property 'includes' of undefined

Swiper version

8.4.0

Platform/Target and Browser Versions

React

Validations

  • Follow our Code of Conduct
  • Read the docs.
  • Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
  • Make sure this is a Swiper issue and not a framework-specific issue

Would you like to open a PR for this bug?

  • I'm willing to open a PR
@serdarjan1995
Copy link

I can confirm the issue is valid, as quick workaround we had to use swiper 8.3.2 version.

@jablonski
Copy link

Same problem here...

TypeError: e.type.displayName is undefined

@fiveable-jferg
Copy link
Author

Thanks for the quick response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants