Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't call process.exit(0) on success. #11

Merged
merged 1 commit into from
Sep 20, 2016

Conversation

ymichael
Copy link
Contributor

This causes commands like optimize-js large-file.js to not output the full output to stdout.

To repro:

$ curl -O https://code.jquery.com/jquery-3.0.0.min.js
$ optimize-js jquery-3.0.0.min.js  | wc
// 3     982   65536
$ optimize-js jquery-3.0.0.min.js > foo.js
$ cat foo.js | wc
//  5    1312   86638

This causes commands like `optimize-js large-file.js` to not output the full output to stdout.

To repro:
```
$ curl -O https://code.jquery.com/jquery-3.0.0.min.js
$ optimize-js jquery-3.0.0.min.js  | wc
// 3     982   65536
$ optimize-js jquery-3.0.0.min.js > foo.js
$ cat foo.js | wc
//  5    1312   86638
```
@nolanlawson
Copy link
Owner

Whoops thanks, that's a bad bug!

@nolanlawson nolanlawson merged commit 3951a47 into nolanlawson:master Sep 20, 2016
@nolanlawson
Copy link
Owner

/me forgot that console.log() is async now

@nolanlawson
Copy link
Owner

fixed in 1.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants