fix: fix visibility warnings #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
made `SortResult` struct + members public so they can be accessed by external libraries
TomAFrench
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
made
SortResultstruct + members public so they can be accessed by external librariesDescription
Problem*
External libraries (e.g.
noir_json_parse) need to query the members of theSortResultobject returned bysort_advanced. This was triggering compiler warnings as these members were private. This PR makes them publicSummary*
struct SortResultis now public, as well as its members.compiler warnings for nargo 0.37 have been fixed
Additional Context
PR Checklist*
cargo fmton default settings.