Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(acvm): Update to acvm 0.4.1 #779

Merged
merged 5 commits into from
Feb 9, 2023
Merged

feat(acvm): Update to acvm 0.4.1 #779

merged 5 commits into from
Feb 9, 2023

Conversation

vezenovm
Copy link
Contributor

@vezenovm vezenovm commented Feb 9, 2023

Related issue(s)

No issue as this is dependency upgrade.

Description

aztec_backend master was updated to acvm 0.4.1 so we want to upgrade the acvm used by Noir as well. This adds the Log directive as well which enable merging the log statements PR. I pushed this PR for now as I have a little cleanup to do on the log statements PR and we should upgrade Noir to the same acvm as aztec_backend.

Summary of changes

There was one renaming change in acvm that had to be updated here in Noir

Dependency additions / changes

Test additions / changes

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.
  • This PR requires documentation updates when merged.

Additional context

@vezenovm vezenovm changed the title Update to acvm 0.4.1 feat(acvm): Update to acvm 0.4.1 Feb 9, 2023
@kevaundray kevaundray self-requested a review February 9, 2023 12:42
@kevaundray kevaundray added this pull request to the merge queue Feb 9, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 9, 2023
@vezenovm vezenovm added this pull request to the merge queue Feb 9, 2023
@kevaundray kevaundray removed this pull request from the merge queue due to a manual request Feb 9, 2023
@kevaundray kevaundray added this pull request to the merge queue Feb 9, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 9, 2023
@vezenovm vezenovm added this pull request to the merge queue Feb 9, 2023
Merged via the queue into master with commit 6f57e86 Feb 9, 2023
@vezenovm vezenovm deleted the mv/update-acvm-0.4.1 branch February 9, 2023 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants