-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli)!: Add --unstable-features
to gate unstable features
#7449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--unstable-features item1,item2,item3,..
or -Zfeature
to gate unstable features--unstable-features
to gate unstable features
Hmm looks like CI is broken for some reason because I added a new workspace package. I'll resolve it after lunch but the PR should still be ready for review. Edit: Completely missed the new crate in git since it was in |
aakoshh
reviewed
Feb 19, 2025
vezenovm
reviewed
Feb 19, 2025
aakoshh
reviewed
Feb 19, 2025
michaeljklein
requested changes
Feb 19, 2025
michaeljklein
approved these changes
Feb 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves #7423
Summary*
Adds the CLI flag
--unstable-features
(or-Z
) to nargo for all compile sub-commands which accepts a list of unstable features to enable. Without this, usage of these features is now a hard error (previously a warning), making this a breaking change. The list of features to accept can be separated by commas:-Zenums,array-ownership
or by specifying the same flag multiple times:-Zenums -Zarray-ownership
.Currently the only unstable features are:
&
and move semantics for arrays)Additional Context
I'm using the name "unstable features" to match rust a bit more closely although previously we used "experimental features." I'm open to naming debates since this is a public facing flag we shouldn't change once it is stabilized.
Documentation*
Check one:
PR Checklist*
cargo fmt
on default settings.