Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow shadowing in match patterns #7424

Closed
jfecher opened this issue Feb 18, 2025 · 0 comments · Fixed by #7484
Closed

Allow shadowing in match patterns #7424

jfecher opened this issue Feb 18, 2025 · 0 comments · Fixed by #7484
Assignees
Labels
enhancement New feature or request

Comments

@jfecher
Copy link
Contributor

jfecher commented Feb 18, 2025

Problem

From #7312 (comment)

The initial match compiler PR disallowed shadowing in match patterns since it leaves error checking for later PRs and we'd need a new error to check that the same name isn't defined multiple times in the same pattern.

Happy Case

We should implement this check and remove the TODO

Workaround

None

Workaround Description

No response

Additional Context

No response

Project Impact

None

Blocker Context

No response

Would you like to submit a PR for this Issue?

None

Support Needs

No response

@jfecher jfecher added the enhancement New feature or request label Feb 18, 2025
@jfecher jfecher self-assigned this Feb 18, 2025
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Feb 18, 2025
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

1 participant