Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if struct methods can have the #[export] tag applied and if so disallow it. #6526

Closed
TomAFrench opened this issue Nov 15, 2024 · 0 comments · Fixed by #6626
Closed

Check if struct methods can have the #[export] tag applied and if so disallow it. #6526

TomAFrench opened this issue Nov 15, 2024 · 0 comments · Fixed by #6626
Assignees
@aakoshh

Comments

@TomAFrench
Copy link
Member

We disallow applying the #[test] attribute to struct and trait methods but we potentially allow the #[export] trait. We should ensure that the same restrictions are in place here.
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Nov 15, 2024
@aakoshh aakoshh mentioned this issue Nov 26, 2024
Merged
5 tasks
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aakoshh aakoshh

Labels
None yet
Projects
Noir
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix!: Disallow #[export] on associated methods noir-lang/noir
2 participants
@aakoshh @TomAFrench