Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Bors into the CI #292

Closed
kevaundray opened this issue Jul 22, 2022 · 3 comments · Fixed by #744
Closed

Integrate Bors into the CI #292

kevaundray opened this issue Jul 22, 2022 · 3 comments · Fixed by #744
Assignees
Labels
enhancement New feature or request

Comments

@kevaundray
Copy link
Contributor

Link to Bors: https://github.com/bors-ng/bors-ng

@kevaundray kevaundray added the enhancement New feature or request label Jul 22, 2022
@jfecher jfecher mentioned this issue Jul 22, 2022
@kevaundray
Copy link
Contributor Author

We added this, but it's not being used -- what are your thoughts on this @jfecher ?

@jfecher
Copy link
Contributor

jfecher commented Jan 23, 2023

I've never had a need to use it. We can check in with the tooling team to see if it'd be desirable to integrate it more closely, if not then I'd suggest removing it.

@phated
Copy link
Contributor

phated commented Jan 24, 2023

It seems that the bors workflow isn't setup as a workflow that runs with an on and produces an error constantly in the Actions tab.

I had never heard of bors, so I just skimmed their https://github.com/bors-ng/bors-ng#but-dont-githubs-protected-branches-already-do-this

They call out:

In addition to the testing requirements, GitHub can also be set to block pull requests that are not "up to date" with the main branch, meaning that problems like this can't show up. This fixes the problem, by requiring that the main branch only contain a snapshot of the code that has passed the tests

I'd rather rely on GitHub features, even if they take a little more time, than extra CI runs, especially knowing that we'll have to keep it up-to-date and trust a third-party action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants